Thanks for the feedback.

In the is_joinable check I had attempted to try both join and detach, but in both cases it causes the script to crash perl. If I run it as is I see:

Perl exited with active threads:
        0 running and unjoined
        1 finished and unjoined
        0 running and detached
[download]

I want to be able to access the information in @results, after the _timedCommand has returned. When running the diskpart system call, a few lines of information are printed prior to the point where it asks for user input, it is these lines I would like to get back. I will try the queue and see if that does what I need it to do.

Thanks.

I updated my code to reflect more where I am currently at.

Here is my latest 2 implementations. They both allow me to detach the thread without a hang. Only the first one gets back the information even in the case of it waiting for user input. But I am not sure if either is exactly thread safe, and I am not sure I am using the thread queue as you intended. But this was the way I could get it working.

Implementation 1:

my $queue = new Thread::Queue;
my $command = 'diskpart';
my $status = _timedCommand($command, 90);
if ($status eq 'TIMEOUT') {
    print "\n=======TIMEOUT==========\n";
}
my @ans;
while (my $ref = $queue->dequeue_nb()) {
    if (ref($ref) =~ m/ARRAY/i) {
        push(@ans, @$ref);
    }
    else {
        push(@ans, $ref);
    }
}
print "@ans\n";

sub _timedCommand
{
    my ($command, $time) = @_;
    my $pid :shared;
    my @tmp :shared;

    my $thr = async {
        $pid = open my $fh, "$command |" or die "$!";
        push @tmp, $_ while <$fh>;
        $fh->close();
    };

    while ($thr->is_running() and $time > 0) {
        sleep(1);
        $time--;
    }
    if ($thr->is_joinable()) {
        $thr->detach();
        $queue->enqueue(\@tmp);
        return 'OK';
    }
    else {
        $thr->detach;
        kill 3, $pid;
        $queue->enqueue(\@tmp);
        return 'TIMEOUT';
    }
}
[download]

Implementation 2:

my $queue = new Thread::Queue;
my $command = 'diskpart';

my $status = _timedCommand($command, 90);
if ($status eq 'TIMEOUT') {
    print "\n=======TIMEOUT==========\n";
}
my @ans;
while (my $ref = $queue->dequeue_nb()) {
    if (ref($ref) =~ m/ARRAY/i) {
        push(@ans, @$ref);
    }
    else {
        push(@ans, $ref);
    }
}

print "@ans\n";

sub _timedCommand
{
    my ($command, $time) = @_;
    my $pid :shared;

    my $thr = async {
        $pid = open my $fh, "$command |" or die "$!";
        my @tmp :shared;
        push @tmp, $_ while <$fh>;
        $queue->enqueue(\@tmp);
        $fh->close();
    };

    while ($thr->is_running() and $time > 0) {
        sleep(1);
        $time--;
    }
    if ($thr->is_joinable()) {
        $thr->detach();
        return 'OK';
    }
    else {
        $thr->detach;
        kill 3, $pid;
        return 'TIMEOUT';
    }
}
[download]

In the second implementation I am seeing some wonky stuff when running the diskpart command, at times it @ans is populated and it prints out information, at other times it is not and doesn't. I have to assume its a timing issue, but I am not sure where it would be. For a dir command it works as expected.

Output from Implementation 1:

C:\Sandbox>perl ForkProcessTimeout.pl

=======TIMEOUT==========

 Microsoft DiskPart version 5.1.3565

 Copyright (C) 1999-2003 Microsoft Corporation.
 On computer: USITPAPADGD1C

 DISKPART>
[download]

Output from Implementation 2:

The output is inconsistent:

C:\Sandbox>perl ForkProcessTimeout.pl

=======TIMEOUT==========

 Microsoft DiskPart version 5.1.3565

 Copyright (C) 1999-2003 Microsoft Corporation.
 On computer: USITPAPADGD1C

 DISKPART>

C:\Sandbox>perl ForkProcessTimeout.pl

=======TIMEOUT==========

C:\Sandbox>perl ForkProcessTimeout.pl

=======TIMEOUT==========

 Microsoft DiskPart version 5.1.3565

 Copyright (C) 1999-2003 Microsoft Corporation.
 On computer: USITPAPADGD1C

 DISKPART>
[download]

I think implementation 2 is the way I need to go for it to be threadsafe, but I don't get the consistency in output. Also when I run implementation 2 in the debugger it seems to consistently include the output.

Would you please stop with the scatter gun approach!

There are at least 4 different versions of your code, some in updated posts other two to a post, and it is impossible for me to keep up with them all.

Please post one question at a time and at least wait for a reasonable amount of time for people to respond--remember they may be in different time zones to you, or just busy with their own stuff--before posting more.

For the record. I've just tried 4 different versions of your code here and 3 of them 'work'...with minor changes.

Like: don't use $fh->close; it will cause errors--which if you were using strict and warnings, one of them would tell you about. Use close( $fh ); instead.

Could you please tell me which versions of threads & threads::shared you are using?

---

Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.

"Science is about questioning the status quo. Questioning authority".

In the absence of evidence, opinion is indistinguishable from prejudice.

"Too many [] have been sedated by an oppressive environment of political correctness and risk aversion."

Sorry about that, I just wanted to post my current status to show that I am not just waiting around for someone to do the work for me. I will be better about it.

Versions: threads::shared version 1.12 threads version 1.63

Incidentally I am using use strict; and use warnings; and I am not seeing anything about $fh->close(), not sure why it isn't