Get yourself a copy of Perl Best Practices and lookup the chapter on subroutines. It has many useful suggestions for creating better subs like how to handle named arguments, missing arguments and default argument values.