in reply to Re^2: foreach vs while<>
in thread foreach vs while<>

If you want a line at a time, while (<$fh>) is perfect.

An array would be useful if you need to go through the file multiple times. Or if you need to traverse the file in an odd order. Or if you want to sort the contents. Sometimes, I'll load the entire file into memory so I can use grep or map, although I tend not to use an array in between.

And then there times when you want to load the entire file into a string, so you'd use local $/; $text = <$fh>;.

And then there are files which don't have a concept of lines, so you'd use read or sysread.

One this is for certain is that there is no reason to do @a = <$fh>; for (@a) unless you do something else with @a. That's the same thing as doing for (<$fh>), and there's no reason for that.

Replies are listed 'Best First'.
Re^4: foreach vs while<>
by JavaFan (Canon) on Nov 12, 2008 at 12:21 UTC
    One this is for certain is that there is no reason to do @a = <$fh>; for (@a) unless you do something else with @a.
    That's not true. There's an advantage 
        @a = <$fh>;
    for (@a) { .. }

    [download]
    gives you which 
        while (<$fh>) { .. }

    [download]
    doesn't give you which may be useful sometimes. Doing @a = <$fh> means you're done reading the file before processing it. If you have a lock on the file, you can then release it. But if you are doing 
        while (<$fh>) { .. }

    [download]
    you're only done reading the file after you've processed almost everything (and one typically releases a lock after processing everything). Now, most of the time, this doesn't matter because noone else needs the file (so you don't have locks, and the file doesn't get modified), or the processing goes fast (so there isn't much difference).

    But it goes to far to say "there's no reason to do @a = <$fh>; for (@a)". Sometimes, there is.

[reply]
[d/l]
[select]

      If you have a lock on the file, you can then release it.

      I had considered that possibility. That would be 

      @a = <$fh>;
close $fh;
for (@a) { .. }

      [download]

      There are reasons to load the file into an array. That's one of them, and I listed four others. But that's not the code the OP posted, and that's not the code I proclaimed should be avoided. You did not contradict me, or do you think I've already contradicted myself four times?

[reply]
[d/l]
      A reply falls below the community's threshold of quality. You may see it by logging in.

In Section Seekers of Perl Wisdom