in reply to Re^2: Sharing and over-riding package functions
in thread Sharing and over-riding package functions

Right, so you think of your packages as function suites.

package Functions::Base; use strict; use Exporter; our @ISA = qw(Exporter); our @EXPORT_OK = qw(func1 func2 func3); sub func1 { print "hello"; } sub func2 { print "kind"; } sub func3 { print "world"; } return 1;

and

package Functions::Alternate; use strict; use Exporter; use Functions::Base (@Functions::Base::EXPORT_OK); our @ISA = qw(Exporter); our @EXPORT_OK = (@Functions::Base::EXPORT_OK, qw (funcx funcy) ); # func1 is going to be replaced with our own no warnings 'redefine'; sub func1 { print "goodbye"; } # func2 is going to be replaced with our own sub func2 { Functions::Base::func2(); print "(haha)"; } use warnings 'redefine'; # func3 is reused from orig::functions unchanged # a couple new functions sub funcx { print "new x"; } sub funcy { print "new y"; } return 1;

and

package Functions; use strict; use Exporter; use Functions::Base qw(func1 func3); use Functions::Alternate qw(func2); our @ISA = qw(Exporter); our @EXPORT_OK = (func1 func2 func3); return 1;

so for subroutines

use strict; use Functions::Base qw(func1 func2 func3); func1; func2; func3; print "\n";

or

use strict; use Functions::Alternate qw(func1 func2 func3); func1; func2; func3; print "\n";

or

use strict; use Functions qw(func1 func2 func3); func1; func2; func3; print "\n";

I'd also note that by printing the functions which contain print statements, you are uselessly printing the functional return values, which will be 1. Thus, you are appending 1 to the end of your outputs for each call.

Replies are listed 'Best First'.
Re^4: Sharing and over-riding package functions
by ruzam (Curate) on Dec 12, 2008 at 01:05 UTC

    That's basically the same code I started with. The only real difference between your example and mine is that in Functions::Alternate I chose not imported the functions I was replacing to avoid redefine warnings, where as you chose to import all functions and quiet the redefine warnings. I must admit though, your slant avoids having to manually keep track of what functions have been replaced, which is a nice touch.

    But if you read down to my reply to rir you'll find that this approach fails when functions call functions within the same package

    Consider this:
    sub func1 { print "goodbye"; func2(); }

    If func1 isn't also replaced, it will execute Functions::Base::func2() when it's called, not the Functions::Alternate::func2() we're trying to replace. I never realized this when I started the post.

      My Function::Base and Function::Alternate are equivalent to your initial modules with some tweaking, yes. However, if you then use Function as a container for the functions you want you can mix and match at will - that's what I meant by a function suite.

      Nice observation regarding the inheritance problem. You can actually cover that case in OOP since you have a prototype to make sure you call the correct module - perltoot taught me a lot.