Re^3: Email Address in Post Replies,

Chromatic,

I would agree that this code in it's entirety needs to be brought up to speed as far as using hashes, packages and a more current style of scripting.

I don't see where using substitution adds instability or has a problem with accuracy, unless they change the ASCII value for the character '@'.

If I were the OP, and had a choice of re-writing this script, or fixing it for now and coming back to it later, I would code the fix and enjoy the Holiday's.
Sometimes, getting all fancy for such a little straight forward script is not worth the effort.

Comment on Re^3: Email Address in Post Replies,

Replies are listed 'Best First'.
Re^4: Email Address in Post Replies, by chromatic (Archbishop) on Dec 17, 2008 at 22:34 UTC
I don't see where using substitution adds instability or has a problem with accuracy, unless they change the ASCII value for the character '@'. It fixes one symptom but fails to address at least six serious bugs lurking in the hand-rolled parsing code, including the root cause of this problem. Sometimes, getting all fancy for such a little straight forward script is not worth the effort. Sometimes, shorter and simpler code is easier to maintain -- especially in this case, where this particular bug would not have been present at all. If that makes code "fancy" and that's a bad thing, so be it.	[reply]

Replies are listed 'Best First'.

Re^4: Email Address in Post Replies,
by chromatic (Archbishop) on Dec 17, 2008 at 22:34 UTC

I don't see where using substitution adds instability or has a problem with accuracy, unless they change the ASCII value for the character '@'.

It fixes one symptom but fails to address at least six serious bugs lurking in the hand-rolled parsing code, including the root cause of this problem.

Sometimes, getting all fancy for such a little straight forward script is not worth the effort.

Sometimes, shorter and simpler code is easier to maintain -- especially in this case, where this particular bug would not have been present at all. If that makes code "fancy" and that's a bad thing, so be it.

[reply]