in reply to faster way for multiple foreach loops

Update 2: The OP changed the inner while loop. This node is bunk.

What do you consider a "loop". If you are considering the outer while() to be a loop, then I would expect it to take a little while. You are iterating scalar(@list)*301*201 or over 500K times for each while.

The logic baffles me, however. Your inner loop is iterating over all of the items in @list1, and even going well beyond the end of the list, but it looks to me like you only want to loop over them with a step value of 3. Perhaps a loop like:

$indx = 0; while ($indx < $count1) { $var1 = $num1 + $list1[$indx++]; $var2 = $num2 + $list1[$indx++]; $var3 = $list1[$indx++]; # further code... }

Please note the difference between $list1[$indx...] and @list1[$indx...]. The first (my code) accesses a list element. The second (yours), if you use strict and warnings, should complain to you, and tell you to use the $list[...] form (that is, after you declare your variables with my).

Update: I just did some testing, and your code, 100 times, executes in 41.6 seconds. Mine (yes, it is doing something different, although I suspect, correct) executes in 8.3 seconds. I would also concur with the above poster that the Further code will make a huge difference.

Update2: To the original poster, please DO NOT update your original node without marking it as such, especially code sections. Your inner loop was originally  foreach(1..$count1) {...}.

--MidLifeXis

Replies are listed 'Best First'.
Re^2: faster way for multiple foreach loops
by ikegami (Patriarch) on Jan 03, 2009 at 14:09 UTC

    Your inner loop is iterating over all of the items in @list1, and even going well beyond the end of the list,

    No it doesn't. It reads @list1 three at a time from start to end over and over again.

      OP Changed code.

      --MidLifeXis