Re: Removing duplicate lines from a file

Much better, but you should also learn about perltidy :). You should start all your scripts with:

use warnings;
use strict;
[download]

this will help you to catch errors like this:

if ($index == scalar(@softed)){
[download]

note softed here. Also you can write

unless ($prev eq $line){
    push (@filtered,$prev);                
}
[download]

instead of

if ($prev eq $line) {
}
else {
    push (@filtered,$prev);                
}
[download]

Comment on Re: Removing duplicate lines from a file Select or Download Code

Replies are listed 'Best First'.
Re^2: Removing duplicate lines from a file by johngg (Canon) on Jan 19, 2009 at 23:46 UTC
... Also you can write `unless ($prev eq $line){ push (@filtered,$prev); }` [download] I would go a little further by using a statement modifier and I'd also omit the brackets around the push arguments. That saves typing two pairs of brackets and a pair of braces and, to my eye, looks clearer; others may disagree. `push @filtered, $prev unless $prev eq $line;` [download] Cheers, JohnGG	[reply] [d/l] [select]
Re^2: Removing duplicate lines from a file by jethro (Monsignor) on Jan 19, 2009 at 22:53 UTC
or equally simple `if (not $prev eq $line) {` or `if ($prev neq $line) {`	[reply] [d/l] [select]