Hi, I have encounter 1 problem in uploading files using perl cgi and I hope you guys can advise me on it.

I keep having this Malformed multipart POST error when uploading files like jpg, gif (binary files). However, when I upload text files, it works. Can I know what could be the problem?

My code for the upload.cgi is shown below:

#!/usr/bin/perl -wT

use strict;
use CGI;
use CGI::Carp qw ( fatalsToBrowser );
use File::Basename;

$CGI::POST_MAX = 1024 * 5000;
my $safe_filename_characters = "a-zA-Z0-9_.-";
my $upload_dir = "/home/nanyang/Codes";

my $query = new CGI;
my $filename = $query->param("file");

if ( !$filename )
{
 print $query->header ( );
 print "There was a problem uploading your file.";
 exit;
}

my ( $name, $path, $extension ) = fileparse ( $filename, '\..*' );
$filename = $name . $extension;
$filename =~ tr/ /_/;
$filename =~ s/[^$safe_filename_characters]//g;

if ( $filename =~ /^([$safe_filename_characters]+)$/ )
{
 $filename = $1;
}
else
{
 die "Filename contains invalid characters";
}

my $upload_filehandle = $query->upload("file");

open ( UPLOADFILE, ">$upload_dir/$filename" ) or die "$!";
binmode UPLOADFILE;

while ( <$upload_filehandle> )
{
 print UPLOADFILE;
}

close UPLOADFILE;
[download]

for the other page which prompts the user to upload file, the code is similar to this:

<form name="frmUpload_File" method="POST" action="upload.cgi" enctype=
+"multipart/form-data">
File to Upload: <input type="file" name="file" />
<p><input type="submit" name="submit" value="Submit" />
[download]

Being stuck on it for a whole day. Please advise!

Thanks!