in reply to Re^7: replace conditionals with polymorphism
in thread replace conditionals with polymorphism
I could do that (no OOP), but that would be premature under-abstraction :-)
No seriously, you make a great point about your having used this module for years and not needing that particular abstraction. And I know you have loads and loads of experience. But let me give a counter story.
One of my first jobs out of school was supervising a team trying to put together a consolidated data model and data dictionary for about 300 coorporate information systems. I learned a lot more than I ever wanted to know about the vagaries of abstraction and language. And most of all I came to the conclusion that there will never be one way to do things and that the best one could do to control confusion was to create good frameworks for doing the same thing many ways. (Maybe that is why I like Perl so much?).
The main reason for OOPing up an implementation is that it provides a framework for TIMTOWTDI. When software is released publicly or across a corporation, it is virtually guarenteed that needs will change across user groups and time. Even during development, customers rarely can articulate or correctly prioritize the corner cases until they've seen a few demos, and by that time, an awful lot of code may be written.
However, just to be clear, I was not suggesting a full scale OOP evangelist style of OOPing up. Most OOP implementations go way overboard creating a mess of interconnected objects that would make a circuit board engineer's eyes cross. They assume that all objects must be mutable. That danger lurks wherever data is accessible to outsiders, etc, etc. Yada, yada, yada..
Rather I had in mind something much simpler. Something that would allow for the possibility that an OOPish need will arise without destroying the overall clarity of your code. How would I do that?
As a first step, I would make changes that do nothing more than make it possible for consumers of the parser to call your parser using an OOP syntax. Internally, aside from the ever-present $self, the object wouldn't really be OOP at all. This would involve little more than
I'm not even sure I would bother giving new(...) parameters (other than $sClass) or even moving the configuration data into a hash. And though I would likely add getter methods for configuration data, I certainly wouldn't bother adding mutators or fancy methods to hide data.
My reasons would be the same as yours - we don't know enough about the way it should be abstracted (yet). Maybe the users don't need to configure the object, they only want to override token processing. Maybe they want to configure, but are ok with doing it only when the object is constructed. Maybe they need a fancy way to add new syntax elements or may be they don't. Maybe they are happy to rely on training and social controls to keep data private and maybe they aren't. We just don't know. All of these can be added later without disrupting existing code. So I would keep it simple.
Ah...but if the changes are so little - why bother? If you really need to, you can do those kind of changes later on. For now they are just fluff...
Why? Because for very little cost, it reduces (not eliminates) the risk that we will have to go out and review 100K or more lines to find all the places we need to change from a function interface to an OOP interface. It reduces the risk that we will need to release a backwards incompatible product to clients. It reduces the risk that we will have to redesign the class to support both a procedural and OOP interface (which will definitely muck up the clarity of your code). It reduces the risk that we have to choose an awkward ordering of parameters just so we can guess which interface is being used. For very little cost and virtually no premature abstraction we create an interface that is more likely to grow in a managable way.
So yes, I agree with minimalism, but the minimalism should be in the design of the object, not in the avoidance of objects.
Best, beth
|
|---|
| Replies are listed 'Best First'. | |
|---|---|
|
Re^9: replace conditionals with polymorphism
by tilly (Archbishop) on Feb 11, 2009 at 19:02 UTC | |
by ELISHEVA (Prior) on Feb 11, 2009 at 21:04 UTC | |
by tilly (Archbishop) on Feb 11, 2009 at 21:42 UTC |