how to find out if move succeeds?

smanicka has asked for the wisdom of the Perl Monks concerning the following question:

Hello monks,

i have a code like this:

if(-e "$newlocationlocation"){
move ($oldlocation,$newlocation) or warn "failed to move to folder";
print LOGFILE "$theTime,moved,$oldlocation,$folder\n";
}
else{
my $perm=775;
mkdir ($newlocation,$perm) or &on_err("Error making Directory\n");
move ($oldlocation,$newlocation) or warn "failed to move to folder";
print LOGFILE "$theTime,moved,$oldlocation,$folder\n";
}
[download]

I actually need to be able to write different stuff into the log based on whether the move succeeds or not.How can I do that?

thanks

Sandhya

Comment on how to find out if move succeeds? Download Code

Replies are listed 'Best First'.
Re: how to find out if move succeeds? by Roy Johnson (Monsignor) on Feb 25, 2009 at 17:48 UTC
You already test the result of `move`, you just don't change what your log writes. You also duplicated code in both branches of the `if`. I think it ought to go something like this: `if (not -e $newlocationlocation) { my $perm = 775; mkdir ($newlocation,$perm) or &on_err("Error making Directory\n"); } if (move ($oldlocation,$newlocation)) { print LOGFILE "$theTime,moved,$oldlocation,$folder\n"; } else { warn "Failed to move to folder"; print LOGFILE "$theTime,failed to move,$oldlocation,$folder\n"; }` [download] Caution: Contents may have been coded under pressure.	[reply] [d/l] [select]

Replies are listed 'Best First'.

Re: how to find out if move succeeds?
by Roy Johnson (Monsignor) on Feb 25, 2009 at 17:48 UTC

move

if

if (not -e $newlocationlocation) {
  my $perm = 775;
  mkdir ($newlocation,$perm) or &on_err("Error making Directory\n");
}
if (move ($oldlocation,$newlocation)) {
  print LOGFILE "$theTime,moved,$oldlocation,$folder\n";
}
else
{
  warn "Failed to move to folder";
  print LOGFILE "$theTime,failed to move,$oldlocation,$folder\n";
}
[download]

Caution: Contents may have been coded under pressure.

[reply]
[d/l]
[select]