Re^2: How to return an appropriate error from module?

I like this idea.

Is there any rule/praxis for or against setting $@ inside my modules or subroutines -- as a way of returning error messages?

If using above example as a guide, would the following module be considered to be "kosher" perl?

package Phone;
sub prettify {
    local ($_) = @_;
    return eval {
        /^$/ and die "No number\n";
        # do something to modify $_ here
        $_;
    };
}
[download]

In my main program this could then be called using:

my $pretty_number = Phone::prettify($number)
if (not defined($pretty_number)) {
    # e.g. insert message $@ into web page output
}
[download]

Comment on Re^2: How to return an appropriate error from module? Select or Download Code

Replies are listed 'Best First'.
Re^3: How to return an appropriate error from module? by ikegami (Patriarch) on Mar 06, 2009 at 16:25 UTC
It is a bit odd. Why not let the exception propagate? `package Phone; sub prettify { local ($_) = @_; /^$/ and die "No number\n"; # do something to modify $_ here $_; }` [download] `my ($pretty_number) = eval { Phone::prettify($number) } or do { ...insert message $@ into web page output... ...exit/return/next/etc... };` [download]	[reply] [d/l] [select]

Replies are listed 'Best First'.

Re^3: How to return an appropriate error from module?
by ikegami (Patriarch) on Mar 06, 2009 at 16:25 UTC

package Phone;
sub prettify {
    local ($_) = @_;
    /^$/ and die "No number\n";
    # do something to modify $_ here
    $_;
}
[download]

my ($pretty_number) = eval { Phone::prettify($number) }
   or do { ...insert message $@ into web page output...
           ...exit/return/next/etc...
         };
[download]

[reply]
[d/l]
[select]