Re^2: Multiple / Mapping Search and Replace

Thanks for the tips. Incorporated and tested fine.

Question: What is better coding practice and quicker?

        if (defined($opt_ignore)) {
            if (defined($opt_reverse)) {
                $map{lc($array[1])} = $array[0]
            } else {
                $map{lc($array[0])} = $array[1]
            }
        } else {
            if (defined($opt_reverse)) {
                $map{$array[1]} = $array[0]
            } else {
                $map{$array[0]} = $array[1]
            }
        }
[download]

$map{ (defined($opt_ignore) ? lc( (defined($opt_reverse) ? $array[1] :
+ $array[0])) : (defined($opt_reverse) ? $array[1] : $array[0])) } = (
+defined($opt_reverse) ? $array[0] : $array[1])
[download]

Comment on Re^2: Multiple / Mapping Search and Replace Select or Download Code

Replies are listed 'Best First'.
Re^3: Multiple / Mapping Search and Replace by graff (Chancellor) on Mar 18, 2009 at 05:22 UTC
I would avoid both of those approaches. The first involves too much repetition of code, and the second is too obfuscated. How about like this: `my ( $src, $dst ) = ( $opt_reverse ) ? ( 0, 1 ) : ( 1, 0 ); if ( $opt_ignore ) { $map{lc($array[$dst])} = $array[$src]; } else { $map{$array[$dst]} = $array[$src]; }` [download] (I hope I got the polarity right on what "reverse" means, but in any case, I think you can see the point.) (update: got rid of the "defined()" call -- the option values should just be true or false, and undefined is false) Another update: better solution: `my ( $src, $dst ) = ( $opt_reverse ) ? (0,1) : (1,0); my $key = ( $opt_ignore ) ? lc($array[$dst]) : $array[$dst]; $map{$key} = $array[$src];` [download]	[reply] [d/l] [select]
Re^3: Multiple / Mapping Search and Replace by jwkrahn (Abbot) on Mar 18, 2009 at 01:23 UTC
The first one looks a lot more readable and maintainable. As for speed, you would have to use something like Benchmark to determine which is fastest.	[reply]