daynite has asked for the wisdom of the Perl Monks concerning the following question:

Hi All, i'm learning Perl some scripts. Now i'm working on a file uploading in Perl-CGI. i have a script which retrives the uploaded image from previouse page and display it on browser. Now everything working fine but image alone not displaying on browser. I have given chmod 755 permision for uploadvalid.cgi and 777 permision for 'upload' directory.


That file is given below,

uploadvalid.cgi (path is.... /var/www/cgi-bi/session/cgi/uploadvalid.cgi)


#!/usr/bin/perl -wT
use strict;
use CGI;
use CGI::Carp qw ( fatalsToBrowser );
use File::Basename;
$CGI::POST_MAX = 1024 * 5000;
my $safe_filename_characters = "a-zA-Z0-9_.-";
my $upload_dir = "/var/www/upload";
my $query = new CGI;
my $filename = $query->param("photo");
if ( !$filename )
{
print $query->header ( );
print "There was a problem uploading your photo (try a smaller file).";
exit;
}
my ( $name, $path, $extension ) = fileparse ( $filename, '\..*' );
$filename = $name . $extension;
$filename =~ tr/ /_/;
$filename =~ s/^$safe_filename_characters//g;
if ( $filename =~ /^($safe_filename_characters+)$/ )
{ $filename = $1;}
else { die "Filename contains invalid characters"; }
my $upload_filehandle = $query->upload("photo");
open ( UPLOADFILE, ">$upload_dir/$filename" ) or die "$!";
binmode UPLOADFILE;
while ( <$upload_filehandle> )
{ print UPLOADFILE;}
close UPLOADFILE;
print $query->header ( );
print << END_HTML; <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> <title>Thanks!</title> <style type="text/css"> img {border: none;} </style> </head> <body>

Thanks for uploading your photo!

Your photo:

Photo

</body> </html>
END_HTML

my output on the browser is,

Thanks for uploading your photo!

Your photo:

Photo

i'm using linux system with Apache/2.0.52 (Red Hat).... is there any environmental error. i'm root user. can any one let me know the correction please. Thanks in advance...

Replies are listed 'Best First'.
Re: Proble with image on Perl-CGI
by moritz (Cardinal) on Mar 26, 2009 at 15:12 UTC
    <img src="/var/www/upload/$filename" alt="Photo" />

    If you domain is example.com, the browser will try to load the image http://example.com/var/www/upload/$filename, which is not what you want. You need to supply the path relative to your document root, for example /upload/$filename.

      Hi.. thanks for your reply..

      i have shifted the 'upload' directory from /var/www/upload to var/www/cgi-bin/session/cgi/upload ......

      and in script i have made the below changes,

      my $upload_dir = "/var/www/cgi-bin/session/cgi/upload";

      and

      img src="/upload/$filename" alt="Photo" />

      still it is not working...

        if the URL starts with a /, it is interpreted relative to your domain name, not to the script (sorry if I was unclear about that).

        Please don't move upload directories into a cgi-bin dir, that might be a huge security risk. Let it stay in /var/www/upload, and link to it with href="/upload/$filename".