in reply to Re: (Ovid) Re(2): How many bugs can *you* find
in thread How many bugs can *you* find
Actually, $section can't have regex characters as the code is written, since it simply iterates over the hard-coded items in @sectionsAs written, but not as maintained. {grin}
For this to pass code review for me, there'd either need to be a fix to that line to make it work even when $section has regex chars, or a note put up above saying "don't ever include regex chars in this string... see below".
The reason I flag that is that it creates an intertwining dependency that will be hell for the maintenance programmer down the road. Trust me: I've been that maintenance programmer enough times to know how much I hate those things. That's why my code reviews are so thorough. {grin}
-- Randal L. Schwartz, Perl hacker
|
|---|