in reply to how to improve my script
PS: Am posting a link as am not sure if its allowed to post around 100+ lines of code in a post.It would be preferable in this case if you included the code in "readmore" tags (as described in Writeup Formatting Tips), rather than as a link. You may update your original post to do so.
The way you handle your @files variable is a little confusing to me. You declare it in your main code as my @files;, and you fill it your getfiles sub. But then that sub does something unexpected by returning it as a reference to an array. You should decide whether you want to use it as an ordinary array or as an array reference, not both. I would be surprised if this does not give you problems.
|
---|