only print data ie between two lines

namishtiwari has asked for the wisdom of the Perl Monks concerning the following question:

Hi, Here is my code snippet

#!/usr/bin/perl 
 
my $logFile = $ARGV[0];  
die "usage: $0 <logFile>" unless $logFile;  
die "Logfile $logFile doesn't exist" unless -f "$logFile";  
open($log, "<", $logFile) or die "Can't open $logFile for reading.";  
print "Processing file $logFile...\n";  
my $n = 0; 
my $ArcotIDError_Count = 0; 
my $QnAError_Count = 0; 
my $UPError_Count = 0; 
my $OTPError_Count = 0; 
my $errorCode; 
while( $line = <$log> )  
{  
       $n++;  
    $line =~ tr/\r\n//d; 
    if ($line =~ /recvd AA_BIN_MSG_VER_CHG/)  
    { 
        while( $line = <$log> ) 
        { 
            if($line =~ /Handling NSPAdvice for mechanism \[4\]/)  
            { 
                while ( $line = <$log> )  
                    { 
                        if ($line =~ /Authentication mechanism returne
+d \[(\d+)\]/)  
                        { 
                            my $errorCode = $1; 
                            print "$errorCode\n"; 
                            if ($errorCode != 0 && $errorCode != 1)  
                            { 
                            $ArcotIDError_Count++; 
                            } 
                        } 
                    } 
            } 
        }     
     } 
} 
    print "Total Number Of ArcotID Authentication ErrorCode returned i
+s $ArcotIDError_Count\n";
[download]

This code does not give me correct output. Correct output according to my logfile is 142 but it gives me 352. I want to count it in between these lines

    
starting point-
Apricot Native Server: recvd AA_BIN_MSG_VER_CHG
and
ending point-
(Prepared to Send OK) OR (Sending Invalid credential).
[download]

I can check the begining statement here but for end statement(so that i always get the out between those lines) what change needed in the code. Thanks NT

Comment on only print data ie between two lines Select or Download Code

Replies are listed 'Best First'.
Re: only print data ie between two lines by Corion (Patriarch) on Jun 17, 2009 at 06:57 UTC
You posted a similar question in Comma seperated output and already got the following answers: Re: Comma seperated output, describing and diagnosing your problem Re: Comma seperated output, describing an approach to solving your problem Re^3: Comma seperated output, by me, asking for a detailed description of what you want to happen when) You also posted not getting desired output, to which you also got answers. What parts of the answers you got have you incorporated into your program?	[reply]
Re: only print data ie between two lines by citromatik (Curate) on Jun 17, 2009 at 10:08 UTC
All those `while ( $line = <$log> )` seems to me a bad design of your algorithm. If any of the `if`s inside them fails, you will consume all the input in a inner `while`. It seems that at some point one of your regular expressions inside and `if` statement is failing, thus consuming the rest of the fail. I would also recommend you to `use strict` and `use warnings` in your code, specially in code you are testing and (like this case) is giving problems. I want to count it in between these lines... The range operator (see perlop) could be an alternative for this. Something like (untested): `while (my $line = <$log>){ if (/recvd AA_BIN_MSG_VER_CHG/ .. /?:(Prepared to Send OK\|Sending I +nvalid credential)/){ if (/Handling NSPAdvice for mechanism \[4\]/ .. /whatever_condit +ion_to_reset_this_block/) { if ($line =~ /Authentication mechanism returne +d \[(\d+)\]/) { my $errorCode = $1; print "$errorCode\n"; $ArcotIDError_Count++ if ($errorCode != 0 && $errorCode ! += 1); } } } }` [download] citromatik	[reply] [d/l] [select]
Re^2: only print data ie between two lines by namishtiwari (Acolyte) on Jun 17, 2009 at 11:33 UTC
i got this error message when i ran the code with range operator- `Quantifier follows nothing in regex; marked by <-- HERE in m/? <-- HER +E :(Prepar ed to Send OK\|Sending Invalid credential)/ at Count_ErrorCode.pl line +34.` [download] Thanks NT	[reply] [d/l]
Re^3: only print data ie between two lines by citromatik (Curate) on Jun 17, 2009 at 12:13 UTC
My mistake: `/?:(Prepared to Send OK\|Sending I +nvalid credential)/` [download] should be `/(?:Prepared to Send OK\|Sending I +nvalid credential)/` [download] citromatik	[reply] [d/l] [select]