Hi Monks, I am writing a script that does the following:

1. traverses directory(ies), looking for a file called 'metadata.xml'

2. Looks for a tag called <merchant>

3. Replaces underscores with spaces in value assigned to <merchant> tag.

My script seems to work, but I could use help/tips on the following:

1. creating a backup file of any file that I alter.

2. the directories I look at are originally in zip format. Right now I manually unzip before updating, and then rezip. I'd like to implement a process that unzips the original zip, traverses the directories and modifies the metadata.xml files, rezips the files, and removes any clutter.

3. Any tips on making the code more efficient, elegant, and less redundant..

Thanks!

#!/usr/bin/perl

use strict;
use warnings;
use File::Find;

@ARGV = ('.') unless @ARGV;

my $dir = shift @ARGV;

find(\&edits, $dir);

sub edits() {

    my $seen = 0;
    my $file = $_;

    if ($file eq 'metadata.xml') {

        open (my $file_fh, $file) || die "Can't open $file!\n $!";
        my @lines = <$file_fh>;
        close $file_fh;


        open $file_fh, ">$file";

        foreach my $line ( @lines ) {
            if ($line =~/merchant/) {
                $line =~s/_/ /g;
            }
            print $file_fh $line;
                $seen++;
        }

        close $file_fh;
    }

    print "Updated $File::Find::name\n" if $seen > 0;
}
[download]