in reply to my first packet sniffer in perl

please do give the feedback......
You should post code that someone can download and compile without errors. Since you are new to the Monastery, you should re-read Writeup Formatting Tips, then try to download the code yourself, and try to run it. It is full of "br" tags, and the code itself has syntax errors:

Do not capitalize 'strict': use strict;

$pkt was never assigned a value; you probably meant to use $packet.

$data=~s/[^-A-Za-z0-9]/./g needs a semicolon at the end. Also, you could take advantage of regular expression CHARACTER CLASSES to make the code less 'noisy'.

Your code would be easier on the eyes if you made better use of whitespace. Try running your code through perltidy.

any suggestions (or abuse) would be gladly accepted at the same email id
The convention here at the Monastery is to provide constructive feedback as a reply to your node here, not via email.

Update:

use Strict; #i usually don't use it
You should always use strict and warnings.

Replies are listed 'Best First'.
Re^2: my first packet sniffer in perl
by hnd (Scribe) on Jun 29, 2009 at 14:07 UTC
    i think that now its ok.......
    and i never meant i dont use strict i wrote it by mistake....... sorry........
    and the character classes.......... um.... i cant figure out what could be more efficient.......
    anyways is the overall code fine?????
[reply]

      so you thought "I'll just add use Strict; then they won't know how slack a programmer I really am.". Unfortunately, as is evident from the replies you already have, bad habits shine through. Always use strictures (use strict; use warnings; - see The strictures, according to Seuss).

      True laziness is hard work
[reply]
[d/l]
        respected grandfather
        i never meant to write down those things (the comments with strict) i meant it to be somewhere else not with strict pragma... i'am really very sorry to write it down there by mistake
        but is the code alright? i mean is there a major mistake?
        i compiled it on my ubuntu but unfortunately i dont have a LAN to sniff out packets so you see i cannot compile it successfully.....
[reply]

In Section Meditations