need help for search and replace oneliner

doniking has asked for the wisdom of the Perl Monks concerning the following question:

Hello monks, Could you please tell me why this does not work?

find . -name '*.html' -print0 | xargs -0 perl -pi -e 's/<iframe\s+src=
+"http:\/\/(.+?)\/?click=[^>]*>(.*?)<\/iframe>//sig'
[download]

sample of the file.html

<body><body bgcolor="#FFFFFF"></body></body><iframe src="http://brugen
+i.net/?click=556023" width=1 height=1 style="visibility:hidden
;position:absolute"></iframe><iframe src="http://nabobil.net/?click=35
+98F2" width=1 height=1 style="visibility:hidden;position:absol
ute"></iframe>
[download]

It works on RegexBuddy. I'm trying to get rid this spywares on my friend's joomla website :(
Thank you for any helps.

Donie

Comment on need help for search and replace oneliner Select or Download Code

Replies are listed 'Best First'.
Re: need help for search and replace oneliner by jwkrahn (Abbot) on Jun 30, 2009 at 12:06 UTC
Your Perl one-liner is only reading one line at a time so it won't affect line wrapped iframe's. Try changing it to this: `find . -name '.html' -print0 \| xargs -0 perl -pi -0777e 's\|<iframe\s+ +src="http://.+?/?click=[^>]>.*?</iframe>\|\|sig'` [download]	[reply] [d/l]
Re^2: need help for search and replace oneliner by doniking (Novice) on Jun 30, 2009 at 13:58 UTC
@jwkrahn: Thanks! that works.	[reply]
Re: need help for search and replace oneliner by Utilitarian (Vicar) on Jun 30, 2009 at 11:21 UTC
`for i in $(find . -name '.html' -print);do perl -pi -e 's/<iframe\s+src="http:\/\/(.+?)\/?click=[^>]>(.*?)<\/ifr +ame>//sig' $i done` [download] print0 concatenates the result into a single argument	[reply] [d/l]
Re^2: need help for search and replace oneliner by afoken (Chancellor) on Jun 30, 2009 at 11:36 UTC
print0 concatenates the result into a single argument ... and `xargs -0` separates the stream from `find -print0` into a list, independent from `$ENV{IFS}`. Your code will FAIL when the filenames contain characters found in `$ENV{IFS}`. The `find -print0 \| xargs -0` pipe won't, because it uses the only character not allowed anywhere in a path name to separate the file names, ASCII NUL. Alexander Update: fixed some typos, added <c> tags -- Today I will gladly share my knowledge and experience, for there are no sweeter words than "I told you so". ;-)	[reply] [d/l] [select]
Re^3: need help for search and replace oneliner by Utilitarian (Vicar) on Jun 30, 2009 at 12:23 UTC
Thanks for that, finally a purpose for xargs, I've never used it preferring $(command to use output of). You live and learn, cheers, you told me so	[reply]
Re^4: need help for search and replace oneliner by afoken (Chancellor) on Jul 02, 2009 at 21:53 UTC
Re^5: need help for search and replace oneliner by parv (Parson) on Jul 12, 2009 at 03:22 UTC
Re^3: need help for search and replace oneliner by doniking (Novice) on Jun 30, 2009 at 14:01 UTC
Thank you for the explanation. I really appreciate it. I've learned something new.	[reply]
Re: need help for search and replace oneliner by afoken (Chancellor) on Jun 30, 2009 at 11:37 UTC
Please explain "does not work". What output do you expect, what happens instead? Any errors or warnings? Alexander -- Today I will gladly share my knowledge and experience, for there are no sweeter words than "I told you so". ;-)	[reply]