Useless use of private variable

Sun751 has asked for the wisdom of the Perl Monks concerning the following question:

Replies are listed 'Best First'.
Re: Useless use of private variable by ikegami (Patriarch) on Jul 15, 2009 at 05:17 UTC
`for ($s; ^^ useless` [download] Fix: `my $s = 0; for (; $s<=$s_no; $s++)` [download] Better fix: `for (my $s=0; $s<=$s_no; $s++)` [download] Even better fix: `for my $s (0..$s_no)` [download]	[reply] [d/l] [select]
Re: Useless use of private variable by Sandy (Curate) on Jul 15, 2009 at 02:49 UTC
The "useless use of private variable" refers to the `$s` in your `for` loop because the variable is never being used. A more perlish way of looping over a bit of code a fixed number of times (one of many ways actually) is `foreach (1 .. $s_no)` [download] Sandy	[reply] [d/l] [select]
Re^2: Useless use of private variable by Sun751 (Beadle) on Jul 15, 2009 at 03:10 UTC
as I am using the value of $s as index number for array, `my $command = $CFG::CFG[$s]->{'CMD'}` [download] using foreach I don't see any possibility if I want to iterate over my array? Any suggestion?? Cheers.	[reply] [d/l]
Re^3: Useless use of private variable by Marshall (Canon) on Jul 15, 2009 at 04:40 UTC
$s should be ok here. I suspect that $$p ( `$$p=$$p-1;`)could be the cause here? I'm not sure as I didn't get that error in my simple testing. I don't see much point in using a ref to $p. I would pass p itself, change this $$p line to $p--; and then return($p); at the end of the sub. I suppose its also possible that you did pass $p instead of \$p and this error message is a referencing error. Update: Looked again. `$CFG::CFG[$s]->{'CMD'};` also looks a bit odd. I'd like to see some more code and explanation of what you think that this CFG data structure looks like. Maybe you intend an array of Hash? I'm not sure from this code. $CFG isn't defined anywhere that I can see. What I said above shouldn't actually matter from functionality or compile errors. If you are going to use a ref, passing a ref to this $CFG thing is the place. Normally passing a ref to a scalar is not necessary or desirable as Perl can return multiple lvalues. Update Again: I didn't see the missing $s=0 in the for loop. Even so this code sans `$CFG::CFG[$s]->{'CMD'};` compiled and ran on my Perl 5.10 machine.	[reply] [d/l] [select]
Re: Useless use of private variable by jbt (Chaplain) on Jul 15, 2009 at 03:01 UTC
$s is only useful in the for loop: `sub validate { my ($p,$s_no) = @_; for (my $s = 0; $s<=$s_no; $s++) { my $command = $CFG::CFG[$s]->{'CMD'}; if ($command =~ /cd /) { $$p = $$p - 1; } } }` [download]	[reply] [d/l]