in reply to Framework.pm 0.01a
They want a special section for that.
I think that this post is an excellent example of why it doesn't happen. This is code that boo_radley clearly put work and thought into. He asked directly for feedback. While plenty duly voted him up, so far nobody was willing to put their neck on the line and put out the energy to give him any.
My opinion is that this happens because enough code to be useful for review is enough code to be more work than most people want to put out. Also when dealing with code that is meant to be good, and has nothing glaringly wrong with it, people don't generally feel comfortable criticizing.
Unfortunately I don't have energy to follow this up with a real dialog. But I will put down a baker's dozen of things that I noticed and think could be done differently. I sincerely hope that someone else follows up with a third opinion on some of these issues (or anything else you see)...
Note that this does not import. If the modules are OO, then that should not matter. Note that if the module was already loaded, then the above will avoid redoing work.# Load a package sub load_lib { my $pkg = shift; my $file = $pkg; $file =~ s/::/\//g; $file .= ".pm"; require $file; }
|
|---|
| Replies are listed 'Best First'. | |
|---|---|
|
Re: Re (tilly) 1: Framework.pm 0.01a
by boo_radley (Parson) on May 06, 2001 at 21:42 UTC |