Re^4: Subroutine references inside of a hash with arguments.

and additional/override arguments can easily be included in your approach.
"1" => sub { get_ifc_name({'ifc_default' => 'test_me', %{shift} }) },

don't you think that an explicit currying function like setdefaults(), is clearer, better maintainable, more DRY and scalable?

I supposed there are more than just one coderef to be parameterized.

~~And even if there is just one, IMHO the above "literal" code is not immediately understood by many coders...~~ changed my mind it's not so obscure, if you only need one currying at all it might be better this way. :-)

Cheers Rolf

Comment on Re^4: Subroutine references inside of a hash with arguments. Download Code

Replies are listed 'Best First'.
Re^5: Subroutine references inside of a hash with arguments. by ig (Vicar) on Jul 26, 2009 at 20:48 UTC
I see advantages and disadvantages in each alternative, leaving me quite ambivalent. They are close enough that I think it would be difficult to make a seriously bad decision between them. Which implementation is clearer will depend on what the reader/developer is familiar with. I would have thought the "literal" code would be more easily understood but your initial reaction proves the point that what is clear is quite personal. The currying function uses a closure which, conceptually, isn't trivial. Otherwise, there is little difference in the set of language features used. On this basis, I would say the currying function is a little less "clear". But, for those familiar with closures, I guess it is at least as clear. The currying function allows the function and default arguments to be set with minimal clutter at the expense of "hiding" what is being done with the arguments in a "remote" block of code. Not much of a problem when that block is adjacent to the function call as in the example, but at least a slight impediment to easy understanding if they are at a greater distance. I agree the currying function is more DRY. Also, if there are many functions being set, it makes it much clearer that they are all being handled in the same way. This clarity should improve scalability. This and the reduction of typing should improve maintainability. The significance of this advantage increases as the scale of the project (number of functions being set) increases. Yet, there is also clarity and ease of maintenance in the terseness and immediacy of ikegami's implementation, particularly for smaller (fewer functions) projects.	[reply]

Replies are listed 'Best First'.

Re^5: Subroutine references inside of a hash with arguments.
by ig (Vicar) on Jul 26, 2009 at 20:48 UTC

I see advantages and disadvantages in each alternative, leaving me quite ambivalent. They are close enough that I think it would be difficult to make a seriously bad decision between them.

Which implementation is clearer will depend on what the reader/developer is familiar with. I would have thought the "literal" code would be more easily understood but your initial reaction proves the point that what is clear is quite personal.

The currying function uses a closure which, conceptually, isn't trivial. Otherwise, there is little difference in the set of language features used. On this basis, I would say the currying function is a little less "clear". But, for those familiar with closures, I guess it is at least as clear.

The currying function allows the function and default arguments to be set with minimal clutter at the expense of "hiding" what is being done with the arguments in a "remote" block of code. Not much of a problem when that block is adjacent to the function call as in the example, but at least a slight impediment to easy understanding if they are at a greater distance.

I agree the currying function is more DRY. Also, if there are many functions being set, it makes it much clearer that they are all being handled in the same way. This clarity should improve scalability. This and the reduction of typing should improve maintainability. The significance of this advantage increases as the scale of the project (number of functions being set) increases.

Yet, there is also clarity and ease of maintenance in the terseness and immediacy of ikegami's implementation, particularly for smaller (fewer functions) projects.

[reply]