Re: Ini files

You didn't say what is going wrong with your code.
I suggest adding this after tie'ing the ini-file:

use Data::Dumper;
print Dumper(\%ini)."\n";
[download]

And you have two typos:

        push @slots, keys%{$ini{'$hostnames[$i}'}};
        push @ifindices, values%{$ini{'$hostnames[$i}'}};
[download]

The closing bracket for [ should be ] instead of }

The ' chars within $ini{} make Perl treat this as a string and I don't think that there is a [$hostnames[$i}] - block in your file :-) Just remove the ' there.

These things are usually very hard to find expecially if you're working on a piece of code for a longer time without breaks. Usually, I add a print in those cases and _copy&paste_ the variables which don't work there. If you re-type them, you may loose some typos and will get even more confused.

Please remember, that keys() and values() don't return the same order of items, so you won't get any associations between slots and ifindices. Try

for (keys(%{$ini{$hostnames[$i]}})) {
 push @slots,$_;
 push @ifindices,${$ini{$hostnames[$i]}}{$_};
}
[download]

Last note:
If you don't really need $i, you could advoid it:

for (@hostnames) { print $_; }
[download]

In this loop, $_ is the same as $hostnames[$_] in your loop. For nested loops:

for my $Hostname (@hostnames) { print $Hostname; }
[download]

Comment on Re: Ini files Select or Download Code

Replies are listed 'Best First'.
Re^2: Ini files by Ravendark (Acolyte) on Sep 04, 2009 at 09:36 UTC
this: `for (keys(%{$ini{$hostnames[$i]}})) { push @slots,$_; push @ifindices,${$ini{$hostnames[$i]}}{$_}; }` [download] how can I use it? $i is the variable inside the for loop (my $i). What I am trying to do is: to associate slots with indices for every host (performance section, pop1 & pop2). The simplest way I thought was with an ini file (since I have worked before with ini files.) Thanks!	[reply] [d/l]
Re^3: Ini files by Sewi (Friar) on Sep 04, 2009 at 11:06 UTC
$_ ist the default variable for loops, you don't need a special inside variable. If you got such a loop (and don't see any commands that could harm your computer), it's wise to `for (keys(%{$ini{$hostnames[$i]}})) { print "Slot: $_\n"; push @slots,$_; print "IfIndex: ${$ini{$hostnames[$i]}}{$_}\n"; push @ifindices,${$ini{$hostnames[$i]}}{$_}; }` [download] This will show you what is happening. Let's split the lines: $hostname[$i] contains your hostname. This is used as a key for the %ini - hash. So we could simplify it for better understanding as `for (keys(%{$Hostpart_from_INI})) {` [download] $Hostpart_from_INI contains a reference to what Config::INI found for this hostname (the one for the current loop run). It is a Hash-Reference, so we could also write: `for (keys(%Host_Data_from_INI)) {` [download] Okay, now we're here with a simple Hash. Each loop run gets another key from the Hash %Host_Data_from_INI. If you got Problems with $_, we could add it: `for $_ (keys(%Host_Data_from_INI)) {` [download] You should try the following for better understanding: `perl -le 'for (1,2,3) { print $_; }'` [download] You could also add the $_ behind the for or you could use any other variable. Still with me? Okay, let's write your loop using the simplified form: `for (keys(%Host_Data_from_INI)) { push @slots,$_; push @ifindices,$Host_Data_from_INI{$_}; }` [download] Remember: We changed nothing, the code is still the same. All we did was renaming things and solving references to show what Perl sees when executing the script.	[reply] [d/l] [select]