in reply to Re: 64 bit integers woes
in thread 64 bit integers woes

Math::BigInt(::FastCalc) numifies values as an NV:

void _num(class,x) SV* x INIT: AV* a; NV fac; SV* temp; NV num; I32 elems; I32 index; NV BASE; CODE: a = (AV*)SvRV(x); /* ref to aray, don't check ref */ elems = av_len(a); /* number of elems in array */ if (elems == 0) /* only one element? */ { ST(0) = *av_fetch(a, 0, 0); /* fetch first (only) element */ XSRETURN(1); /* return it */ } fac = 1.0; /* factor */ index = 0; num = 0.0; BASE = XS_BASE; while (index <= elems) { temp = *av_fetch(a, index, 0); /* fetch current element */ num += fac * SvNV(temp); fac *= BASE; index++; } ST(0) = newSVnv(num);

pack'Q' extracts the value to be packed from the SV using SvUV:

#ifdef HAS_QUAD case 'Q': while (len-- > 0) { Uquad_t auquad; fromstr = NEXTFROM; auquad = (Uquad_t) SvUV(fromstr); #### here! DO_BO_PACK(auquad, 64); PUSH_VAR(utf8, cur, auquad); }

SvUV() silently mangles NVs > 2**53:

printf "%3d %20d %s\n", $_, ( 1 << $_ )-1, unpack 'h*', pack 'Q>', Math::BigInt->new( ( 1 << $_ )-1 ) for 50 .. 60;; 50 1125899906842623 0030ffffffffffff 51 2251799813685247 0070ffffffffffff 52 4503599627370495 00f0ffffffffffff 53 9007199254740991 00f1ffffffffffff 54 18014398509481983 0004000000000000 55 36028797018963967 0008000000000000 56 72057594037927935 1000000000000000 57 144115188075855871 2000000000000000 58 288230376151711743 4000000000000000 59 576460752303423487 8000000000000000 60 1152921504606846975 0100000000000000

After that it gets a little fuzzy. SvUV() appears to be implemented as Perl_sv_2uv_flags(), and if SvNOKp is set (which it would be), then the coersion is done by the macro U_V:

if (SvNOKp(sv)) return U_V(SvNVX(sv));

which is defined in perl.h. There is code to detect out-of-range FP values, but whther it is compiled in or not is dependant upon another #define:

/* This may look like unnecessary jumping through hoops, but convertin +g out of range floating point values to integers *is* undefined behav +iour, and it is starting to bite. */ #ifndef CAST_INLINE #define I_32(what) (cast_i32((NV)(what))) #define U_32(what) (cast_ulong((NV)(what))) #define I_V(what) (cast_iv((NV)(what))) #define U_V(what) (cast_uv((NV)(what))) #else #define I_32(n) ((n) < I32_MAX_P1 ? ((n) < I32_MIN ? I32_MIN : (I32) ( +n)) \ : ((n) < U32_MAX_P1 ? (I32)(U32) (n) \ : ((n) > 0 ? (I32) U32_MAX : 0 /* NaN */))) #define U_32(n) ((n) < 0.0 ? ((n) < I32_MIN ? (UV) I32_MIN : (U32)(I32 +) (n)) \ : ((n) < U32_MAX_P1 ? (U32) (n) \ : ((n) > 0 ? U32_MAX : 0 /* NaN */))) #define I_V(n) ((n) < IV_MAX_P1 ? ((n) < IV_MIN ? IV_MIN : (IV) (n)) \ : ((n) < UV_MAX_P1 ? (IV)(UV) (n) \ : ((n) > 0 ? (IV)UV_MAX : 0 /* NaN */))) #define U_V(n) ((n) < 0.0 ? ((n) < IV_MIN ? (UV) IV_MIN : (UV)(IV) (n) +) \ : ((n) < UV_MAX_P1 ? (UV) (n) \ : ((n) > 0 ? UV_MAX : 0 /* NaN */))) #endif

which apparently isn't being set in 64-bit builds?


Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
"Science is about questioning the status quo. Questioning authority".
In the absence of evidence, opinion is indistinguishable from prejudice.
RIP PCW It is as I've been saying!(Audio until 20090817)

Replies are listed 'Best First'.
Re^3: 64 bit integers woes
by ikegami (Patriarch) on Sep 08, 2009 at 15:02 UTC

    Math::BigInt(::FastCalc) numifies values as an NV:

    That would account for a loss of precision, but it shouldn't result in -1.

    SvUV() silently mangles NVs > 2**53

    Are you sure? The number the OP posted requires 56 bits of precision to be stored in a float (64 bits for an integer). One would think the value was already mangled.

    but whther it is compiled in or not is dependant upon another #define

    CAST_INLINE only determines if the cast is done inline or if a subroutine is called to do the cast. Or where you referring to some unshown #ifdef?

      CAST_INLINE only determines if the cast is done inline or if a subroutine is called to do the cast.

      About 80% of the mass of macros used in Perl would be far better implemented as subroutines with the inline keyword attached. That one step would reduce the clutter in the Perl sources immeasurably, and it'd probably run faster.


      Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
      "Science is about questioning the status quo. Questioning authority".
      In the absence of evidence, opinion is indistinguishable from prejudice.
        It wasn't portable. But that's changed. They were discussing starting to use it. They were all for it. I don't know if they've started using it or not.