in reply to Re: How can I avoid code repetition here
in thread How can I avoid code repetition here

my $str = $change_in_place && $default_argument ? $_ : $_[0];
  $str =~ s/^($lchompstr)*//;
  $_[0];
}

[download]
I think this would (in the case $change_in_place && $default_argument) change only a copy of $_, not $_ itself. Maybe one could somehow use a foreach loop iterating over a one-element list, but I don't see how this would work in the general case.

-- 
Ronald Fischer <ynnor@mm.st>

Replies are listed 'Best First'.
Re^3: How can I avoid code repetition here
by JadeNB (Chaplain) on Oct 17, 2009 at 21:35 UTC 
    my $str = $change_in_place && $default_argument ? $_ : $_[0];
$str =~ s/^($lchompstr)*//;

    [download]
    I think this would (in the case $change_in_place && $default_argument) change only a copy of $_, not $_ itself. Maybe one could somehow use a foreach loop iterating over a one-element list, but I don't see how this would work in the general case.
    I think that you could just take advantage of the fact that “ternary conditionals preserve lvalue-ness”, and write: 
    ($change_in_place && $default_argument ? $_ : $_[0]) =~ s/^(?:$lchomps
+tr)*//;

    [download]
    (I've taken the liberty of making your parentheses non-capturing. :-) ) I'm not sure why you end with the $_[0] statement, though—it seems that you're returning the first argument even if you ignored it (because of $change_in_place and $default_argument).
[reply]
[d/l]
[select]

In Section Seekers of Perl Wisdom