Re^7: Directory Tree Structure

Hi -- Sorry about the slowness to respond to this. I think you're really close here, but I'm not sure how to explain the issue.

First off, I gather that a bunch of the stuff at the top of this latest version of yours is not relevant to the problem: your "%directories" hash, the "get_rootdir" sub and the $root(link|user|name variables are all no-ops. You are just using File::Find on whatever the current working directory happens to be.

So, putting all that extra stuff aside, the only change I think you need in the operative code is this:

sub wanted {
  local $_ = $File::Find::name;
  if ( -f ) {          # only work on data files (skip directories)
    s{\Q$rootdir\E[\\/]}{}; # remove the rootdir string from the path 
+name
                            # ... ALONG WITH THE SUBSEQUENT "\" OR "/"
+ CHARACTER
    load_tree( $tree{$rootdir}, fileparse( $_ ));
  }
}
[download]

I think the point here is: once you get into the first subdirectory, removing just the "$rootdir" string leaves $_ with the path separator character at the start. That somehow causes fileparse() to not play nice with the recursive "load_tree" function. Anyway, try that out and see if it helps.

Comment on Re^7: Directory Tree Structure Select or Download Code

Replies are listed 'Best First'.
Re^8: Directory Tree Structure by Lady_Aleena (Priest) on Nov 05, 2009 at 06:03 UTC
That got rid of the warning, but did not fix the problem. I think I will need to see the basics, meaning no HTML, so that HTML can be added back in as we go. What I need on each line is the file with the full path. `C:/Documents and Settings/XXXX/My Documents/fantasy/<subdir> C:/Documents and Settings/XXXX/My Documents/fantasy/<subdir>/<filena +me_1>.ext C:/Documents and Settings/XXXX/My Documents/fantasy/<subdir>/<filena +me_2>.ext C:/Documents and Settings/XXXX/My Documents/fantasy/<subdir>/<filena +me_3>.ext C:/Documents and Settings/XXXX/My Documents/fantasy/<subdir_2> C:/Documents and Settings/XXXX/My Documents/fantasy/<subdir_2>/<file +name>.ext` [download] -or- `/ftp/pub/www/fantasy/<subdir> /ftp/pub/www/fantasy/<subdir>/<filename_1>.ext /ftp/pub/www/fantasy/<subdir>/<filename_2>.ext /ftp/pub/www/fantasy/<subdir>/<filename_3>.ext /ftp/pub/www/fantasy/<subdir_2> /ftp/pub/www/fantasy/<subdir_2>/<filename>.ext` [download] After we get the files listed properly, then the HTML can be added back in. *Have a nice day!* Lady Aleena	[reply] [d/l] [select]
Re^9: Directory Tree Structure by graff (Chancellor) on Nov 05, 2009 at 06:58 UTC
When you say "got rid of the warning, but didn't fix the problem", do you mean that you are still seeing "empty" lines in the output? I'm not seeing that when I run the version below (sanitized to make it non-dependent on your specific paths). I added the minimal amount of stuff around the "print_tree()" function so that I could load it in a browser and even paste it into this validation tool that almut cited elsewhere in this thread; I see no blank lines in the raw or rendered html, and it passed validation (with just a couple warnings about unrelated stuff). If you're still seeing a problem with your directory tree, maybe there's something strange in the file names that you are dealing with (e.g. html-reserved characters in a file name, or something like that). In that case, it'll be worthwhile to get a plain-text dump of the tree to see if that's the problem -- or better yet, add HTML::Entities to your program, and use its "encode_entities" method on all the file names. In fact, I've gone ahead and done that in the version below, just because it's a good idea anyway. Read more... (2 kB) (updated to fix validation web site link)	[reply] [d/l]
Re^10: Directory Tree Structure by Lady_Aleena (Priest) on Nov 05, 2009 at 19:59 UTC
I think I have figured out why the above works wonky for me. The root directory on my home computer has my name in it. The period after my middle initial is messing up `sub load_tree`. So, can we change the dots to something else? *Have a nice day!* Lady Aleena	[reply] [d/l]
Re^11: Directory Tree Structure by graff (Chancellor) on Nov 05, 2009 at 22:59 UTC