That's because @newdeck is a global variable, and you don't clear it.

I recommend to use strict; use warnings; and declare my @newdeck inside the shuffle sub.

There's also a shuffle function in the core module List::Util, which is tested and works.