Re: Daemon sub refuses to daemonize. Why?

A couple of things I noticed here:

This line causes a complaint about an insecure dependency:

die "Server already running with PID $pid" if kill 0 => $pid;
[download]

Insert this code directly above it to untaint $pid:

if ($pid =~ /^(\d+)$/) {
  $pid = $1;
} else {
  die "funky pid read from $file!";
}
[download]

Comment on Re: Daemon sub refuses to daemonize. Why? Select or Download Code

Replies are listed 'Best First'.
Re: Re: Daemon sub refuses to daemonize. Why? by BMaximus (Chaplain) on May 18, 2001 at 04:44 UTC
Using the `\|\|` or using an `or` works either way on my machine. Running it as an unpriviledged user, the daemon dies saying that it doesn't have permission to create the file. However running it as root and the daemon runs without a hitch except for the fact that no pid file is created. When I look in /var/run for the keeperd.pid file its missing. What could be going wrong here? If keeperd couldn't make the file it should be complaining, but there's every indication that it is making the file. BMaximus	[reply] [d/l] [select]
Re: Re: Re: Daemon sub refuses to daemonize. Why? by converter (Priest) on May 18, 2001 at 05:02 UTC
If this were my code, I would probably not write it this way to begin with. Instead, I would assign the reference returned by IO::File->new to a scalar then check to make sure it's defined. Something like: `my $fh = IO::File->new($file, O_WRONLY\|O_CREAT\|O_EXCL,0644); die "Can't create $file: $!\n" unless defined $fh; return $fh;` [download] Instead of: `return IO::File->new($file, O_WRONLY\|O_CREAT\|O_EXCL,0644) or die "Can't create $file: $!\n";` [download]	[reply] [d/l] [select]