Why don't you try it with some test data and see what the results are? (looks OK to me, btw ...)

Notice, however, that the operation you describe is also known as "getting rid of all the spaces." So you could do the much simpler and faster

$temp_dcr{$dcr_name}{PromotionName} =~ tr/ //d;
[download]

HTH

perl -e 'print "How sweet does a rose smell? "; chomp ($n = <STDIN>); 
+$rose = "smells sweet to degree $n"; *other_name = *rose; print "$oth
+er_name\n"'
[download]