Microsoft (R) COFF/PE Dumper Version 7.00.9466
Copyright (C) Microsoft Corporation.  All rights reserved.


Dump of file blib/arch/auto/Time/Piece/Piece.dll

File Type: DLL

  Section contains the following imports:

    perl510.dll
              10004064 Import Address Table
              10004690 Import Name Table
                     0 time date stamp
                     0 Index of first forwarder reference

                  355 Perl_newXS_flags
                  21A Perl_croak
                  4AB Perl_vstringify
                  4A1 Perl_vcmp
                  1C0 Perl_Iunitcheckav_ptr
                  35A Perl_new_version
                  262 Perl_get_sv
                  254 Perl_form
                  18C Perl_Iscopestack_ix_ptr
                  20F Perl_call_list
                  1B2 Perl_Isv_yes_ptr
                  3F6 Perl_sv_2nv
                  21B Perl_croak_nocontext
                  4B0 Perl_warn_nocontext
                  19C Perl_Istack_max_ptr
                  3EC Perl_stack_grow
                  346 Perl_newSViv
                  19D Perl_Istack_sp_ptr
                  144 Perl_Imarkstack_ptr_ptr
                  19B Perl_Istack_base_ptr
                  21C Perl_croak_xs_usage
                  3F8 Perl_sv_2pv_flags
                  3F4 Perl_sv_2iv_flags
                  2B5 Perl_init_tm
                  3A8 Perl_safesysmalloc
                  3A9 Perl_safesysrealloc
                  348 Perl_newSVpv
                  3F5 Perl_sv_2mortal
                  3A7 Perl_safesysfree
                  25A Perl_get_context
                   9A Perl_Gcurinterp_ptr
                  417 Perl_sv_derived_from
                  507 win32_getenv

    MSVCR70.dll
              10004008 Import Address Table
              10004634 Import Name Table
                     0 time date stamp
                     0 Index of first forwarder reference

                   F5 _except_handler3
                   6E __dllonexit
                   BE _adjust_fdiv
                  142 _initterm
                  204 _strnicmp
                  218 _tzset
                  1CA _putenv
                  2DD localtime
                  2BE gmtime
                  2E9 memset
                  30D strftime
                  2C9 isspace
                  2C3 isdigit
                  2CA isupper
                  311 strncpy
                  2BA getenv
                  308 strcmp
                  30E strlen
                  2E1 malloc
                  302 sprintf
                  2AE free
                  1BB _onexit

    KERNEL32.dll
              10004000 Import Address Table
              1000462C Import Name Table
                     0 time date stamp
                     0 Index of first forwarder reference

                   80 DisableThreadLibraryCalls

  Summary

        1000 .data
        1000 .rdata
        1000 .reloc
        3000 .text
[download]

I've implemented a fix, and having people test it now, just by 
implementing my own version of localtime and gmtime in the module (stu
+pid 
I know, but it works).
[download]

localtime and gmtime are still being imported from msvcr70.dll. Is that what's stuffing things up ?

No. That's what cured the problem with tzoffset(). It means that all the CRT calls used by Time::Piece are now imported from the same version of the CRT, and therefore operate upon the CRT copy of the environment. Previously, those two were being imported from msvcrt.dll, and hence referenced its copy of the environment, while the tzset(), getenv() & putenv() were coming from msvcr70.dll and operating upon its copy.

The failure you're seeing now, is with strftime() & "%Z", which fails to return the timezone name. Which is weird because dumpbin shows strftime() being imported from the right place.

If the module was picking up anything from the wrong runtime, I'd have expected to see it also importing something from mscvrt.dll, but that's not the case.

Which is weird because dumpbin shows strftime() being imported from the right place.

Yes - it's being imported from the right place .... therefore we deduce that the timezone is not being set as intended. I added 3 warn() messages to the relevant section of the 02core.t script. It now looks like:

SKIP: {
    skip "can't register TZ changes in a pseudo-fork", 2 if $is_pseudo
+_fork;
    use POSIX;
    warn "1 POSIX::strftime: ", POSIX::strftime("%Z\n", localtime);
    local $ENV{TZ} = "EST5";
    warn "2 POSIX::strftime: ", POSIX::strftime("%Z\n", localtime);
    Time::Piece::_tzset();  # register the environment change
    warn "3 POSIX::strftime: ", POSIX::strftime("%Z\n", localtime);
    my $lt = localtime;
    cmp_ok(scalar($lt->tzoffset), 'eq', '-18000');
    cmp_ok($lt->strftime("%Z"), 'eq', 'EST');
}
[download]

Using VC 7 and a perl-5.10.0 built by VC 7 everything works fine and the modified script outputs (as desired):

.
.
ok 37
1 POSIX::strftime: AUS Eastern Daylight Time
2 POSIX::strftime: EST
3 POSIX::strftime: EST
ok 38
ok 39
ok 40
.
.
[download]

But using VC 7 with ActivePerl-5.10.1 (or with ActivePerl-5.10.0), the output becomes:

.
.
ok 37
1 POSIX::strftime: AUS Eastern Daylight Time
2 POSIX::strftime: AUS Eastern Daylight Time
3 POSIX::strftime: AUS Eastern Daylight Time
ok 38
not ok 39
#   Failed test at t/02core.t line 65.
#          got: ''
#     expected: 'EST'
ok 40
.
.
[download]

Apparently for this test to work with MSVC++ 7.0 on a perl built by MSVC++ 6, the Time::Piece authors need to devise a way of getting the change to $ENV{TZ} reflected in the right place so that their strtftime call can detect it.

Cheers,
Rob