in reply to Clean way to build URI's?

But somehow, this just seems wrong wrong wrong:

Why?

Replies are listed 'Best First'.
Re^2: Clean way to build URI's?
by moritz (Cardinal) on Feb 02, 2010 at 11:58 UTC
    Because it doesn't URL-encode characters in the interpolated strings, so the outcome is not guaranteed to be a syntactically valid URI.

    Maybe the URI module would be more appropriate?

    Perl 6 - links to (nearly) everything that is Perl 6.
[reply]

      I was asking why the OP thought so. Now we'll never know for sure.

      BTW:URL encoding is easily applied after the interpolation.

[reply]
        BTW:URL encoding is easily applied after the interpolation.

        Not without possible data loss. 

        my $value = 'foo&bar=baz';
my $key   = 'something'

my $url1 = encode_url("http://example.com/script?$value=$key");
my $url2 = 'http://example.com/script?%s=%s', map encode_url_chunk($_)
+, $key, $value;

        [download]

        For proper working functions encode_url and encode_url_chunk (which have to encode different things, of course) the outcome will be different.

        Perl 6 - links to (nearly) everything that is Perl 6.
[reply]
[d/l]
[select]
        No it's not. The encoder would have no way to know which "?" (for example) are separators (can't be encoded) and which "?" are data (must be encoded).
[reply]
Re^2: Clean way to build URI's?
by rastoboy (Monk) on Feb 02, 2010 at 23:16 UTC
    It's just my intuition, to be candid. Some part of my mind just screams "unclean!" :-)
[reply]

      That's kinda what I thought. Thanks for being candid.

      So long as you url-encode your bits before (not after as I accidentally typed above), you interpolate them, pretty much all the complex OO buys you is overhead, because that's pretty much all it is doing under the covers.

      Of course, it may, (probably will be), the case that you can live with the overhead, and even that you like the interface, in which case use the module. But know why you're doing so. What it buys you. And what it doesn't.

      Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
      "Science is about questioning the status quo. Questioning authority".
      In the absence of evidence, opinion is indistinguishable from prejudice.
[reply]
        I see where you're coming from. Good points--thanks for the help!
[reply]

In Section Seekers of Perl Wisdom