Some comments:
- Users personal name is optional; it's a comment field.
- Default password????
- if they still use crypt, they should be sho^H^H^H locked up...
- ++ on the drink beer
My opinion at adding users: use useradd/adduser since it can automatically do most tasks (like autoguessing UID to use, creating homedir with /etc/skel, add *optional* personal name, encode the password correctly {even if it is crypt'ed}, set the correct permissions, etc).
Don't roll your own !
If you're not used to doing stuff like that (let me repeat
*if you're not used to doing stuff like that*) don't do it on a live box...
my $0.02
Greetz
Beatnik
... Quidquid perl dictum sit, altum viditur.