Yes, I am using strict, and the "my $cmd;" line actually appears further up the code. Unless there's a good reason not to, in which case I will happily change it!

There is an excellent reason why you should always use my to declare a for loop variable in the loop - a for loop variable isn't what you think it is! Consider:

my $loopVar = 10;

for $loopVar (1 .. 5) {
    print "$loopVar\n";
}

print $loopVar;
[download]

What do you expect to see printed? What do you actually see printed? Now try this:

my $loopVar = 10;
my @values = (0 .. 4);

for $loopVar (@values) {
    ++$loopVar;
}

print "$loopVar, @values";
[download]

What do you expect to see printed? What do you actually see printed?

A for loop variable is aliased to each element of the for list in turn. When you use a previously declared variable as the loop variable you are really only using the name, the value is untouched.

So, always declare your for loop variable in the loop header because it ain't what you think it is anyway and declaring it make sure everyone gets that idea.

Note that a C style for loop is different and there it does often make sense to use a variable from the scope global to the loop.

---

True laziness is hard work

Great. It's best to restrict it to the smallest possible scope. Having it at the top makes it, more or less, a global which can be seen or persist anywhere in the script. This can lead to lame/long debugging sessions. Better to put it inline with the loop.

Gotcha - thanks!

Kaiti
Swiss Army Nerd