Re^2: Reading sourcecode at parsing/compilation (CHECK) time? ($

thanks, switching to a lexical loop variable solved the problem!

Silly me... I don't know why I was expecting that a core module either treats $_ safely when calling foreign code or documents warnings about possible side effects...

Cheers Rolf

PS: maybe the author should take a look into PBP? (SCNR ;)

Comment on Re^2: Reading sourcecode at parsing/compilation (CHECK) time? ($_) Download Code

Replies are listed 'Best First'.
Re^3: Reading sourcecode at parsing/compilation (CHECK) time? (Ticket) by LanX (Saint) on Apr 04, 2010 at 13:14 UTC
> ... I was expecting that a core module either treats $_ safely when calling foreign code ... I filed a bug report for Attribute::Handlers with an attached diff which solves this issue. http://rt.perl.org/rt3/Ticket/Display.html?id=74052 Cheers Rolf UPDATE: wow already resolved at the following day! Steffen Müller++	[reply]
Re^4: Reading sourcecode at parsing/compilation (CHECK) time? (Ticket) by Anonymous Monk on Apr 05, 2010 at 14:26 UTC
I don't think the error is in the module; the error is that you shouldn't use that kind of while loop without localizing `$_`. More examples are at http://wiki.perl-community.de/Wissensbasis/PerlFallen#Lesen_aus_Datei_und (in German, sorry).	[reply] [d/l]
Re^5: Reading sourcecode at parsing/compilation (CHECK) time? (Ticket) by LanX (Saint) on Apr 05, 2010 at 14:48 UTC
I don't think the error is in the module; maybe "error" is too much to say, let's call it good style not to unnecessarily rely on that foreign code doesn't change $_. At least this module violates several style rules from the same author... Cheers Rolf	[reply]