Re^2: Reading from filehandles in a loop and matching lines

use warnings;
use strict;

open (EMPLOYEES,"employees.txt") or die "Tough: $!\n\n";
while ($line = <EMPLOYEES>) {
  chomp $line;
    ($name,$department, $salary) = split /\t/, $line;

print "n=$name\n"
print "d=$department\n"
print "s=$salary\n"

    next unless$name =~ /^Mr /;
    next unless$salary > 25000;
    next unless$department eq $ARGV[0];

    $name =~ s/Mr//;
    print"$name\n";
}
close (EMPLOYEES);
[download]

The command line i used was ./employee HR. This is the whole script and there are no parameters at the start. These are the errors i am getting;

./employee.pl: line 1: use: command not found
./employee.pl: line 2: use: command not found
./employee.pl: line 5: syntax error near unexpected token `EMPLOYEES,"
+employees.txt"'
./employee.pl: line 5: `open (EMPLOYEES,"employees.txt") or die "Tough
+: $!\n\n";'
[download]

Comment on Re^2: Reading from filehandles in a loop and matching lines Select or Download Code

Replies are listed 'Best First'.
Re^3: Reading from filehandles in a loop and matching lines by choroba (Cardinal) on May 06, 2010 at 01:45 UTC
Looks like shell error messages. Have you deleted the very first line of the script starting with `#!`? Then your shell tries to interpret the script, not perl.	[reply] [d/l]
Re^4: Reading from filehandles in a loop and matching lines by Nathan_84 (Acolyte) on May 06, 2010 at 01:55 UTC
with the first line added i get the following errors l symbol "$line" requires explicit package name at ./employee.pl line +10. Global symbol "$line" requires explicit package name at ./employee.pl +line 13. Global symbol "$name" requires explicit package name at ./employee.pl +line 16. Global symbol "$department" requires explicit package name at ./employ +ee.pl line 16. Global symbol "$salary" requires explicit package name at ./employee.p +l line 16. Global symbol "$line" requires explicit package name at ./employee.pl +line 16. Global symbol "$name" requires explicit package name at ./employee.pl +line 18. syntax error at ./employee.pl line 19, near "print" Global symbol "$name" requires explicit package name at ./employee.pl +line 23. Global symbol "$salary" requires explicit package name at ./employee.p +l line 26. Global symbol "$department" requires explicit package name at ./employ +ee.pl line 29. Global symbol "$name" requires explicit package name at ./employee.pl +line 32. Global symbol "$name" requires explicit package name at ./employee.pl +line 34. Execution of ./employee.pl aborted due to compilation errors. [download]	[reply] [d/l]
Re^5: Reading from filehandles in a loop and matching lines by almut (Canon) on May 06, 2010 at 02:03 UTC
Declare those variables as lexical variables, i.e. put `my` before the first occurrence. And put a semicolon at the end of the prints: `... while (my $line = <EMPLOYEES>) { chomp $line; my ($name,$department, $salary) = split /\t/, $line; print "n=$name\n"; print "d=$department\n"; print "s=$salary\n"; ...` [download]	[reply] [d/l] [select]
Re^5: Reading from filehandles in a loop and matching lines by choroba (Cardinal) on May 06, 2010 at 02:02 UTC
Yes, it is perl. It complains because you turned strict on without tindying the code. See strict. Nevertheless, you have errors in the code like missing semicolons.	[reply]