Re: Recursive sub efficiency

Bugs should be a bigger concern.

You're treating text as a regex pattern in s/$topdir/$recreate_to/.
```
s/\Q$topdir/$recreate_to/
[download]
```

You're using an unlocalised global (*DIR) in a recursive function. You're not using it in a way that would cause a problem, but why?!

    opendir (local *DIR,$dir)
    || die "unable top open dir $dir $!";
    my @files = grep(/\w+/,readdir(DIR));
    closedir (DIR);
[download]

Better:

    opendir (my $dh,$dir)
    || die "unable top open dir $dir $!";
    my @files = grep(/\w+/,readdir($dh));
    closedir ($dh);
[download]

Update: s/close/closedir/

Comment on Re: Recursive sub efficiency Select or Download Code

Replies are listed 'Best First'.
Re^2: Recursive sub efficiency by skywalker (Beadle) on Jun 10, 2010 at 19:44 UTC
The \Q within the pattern match is something ive not noticed before (Ive just taken a look at http://www.perl.com/doc/manual/html/pod/perlre.html) thanks for that, I have had issues before with replacing general text within a regular expression so that will help me out a lot. The only reason that I used an unlocalised global for the directory call was simply due to the size of the script I wrote, I know its not going to be used anywhere else. However Ill take note of your comment for future scripts.	[reply]
Re^3: Recursive sub efficiency by ikegami (Patriarch) on Jun 10, 2010 at 20:24 UTC
The only reason that I used an unlocalised global for the directory call was simply due to the size of the script I wrote If that's true, why did you use "my" for every other variable except that one?	[reply]