in reply to RFC(Tutorial):Text::Table Enable
My suggestions are all in the spirit of refinement, and as such, are mostly nitpicky style opinions.
A more direct node title would be "Text::Table Tutorial".
Since your code snippets do not employ consistent usage of whitespace, I recommend running them through perltidy.
Be consistent with your constructor: prefer Text::Table->new() over new Text::Table
These days, I think lexical filehandles are preferred to bareword filehandles:open (FH,'<',"$file") or die ("ERROR! Opening file $!");
open my $fh, '<', $file or die ("ERROR! Opening file $file $!");
You have done a great job of using code tags for keywords, variables, etc. I think surrounding them with single quotes just adds clutter. For example, use print instead of 'print'.
You should add some output examples to clearly demonstrate what the reader should expect to see when running your code.
is more Perlish as:for(my $i = 0;$i<=$#Dlines; $i++){
perlcritic can automatically advise on such style issue.for my $i (0 .. $#Dlines) {
|
---|