Re: check my code

You can use the perlcritic tool to automatically check your code for best practices. It will point out some tips such as:

Useless interpolation of literal string at line 22, column 13.
Bareword file handle opened at line 26, column 1.
Glob written as <...> at line 36, column 10.  See page 167 of PBP.
Readline inside "for" loop at line 36, column 10.  See page 211 of PBP
+.
[download]

You can also convert your comments to POD and get a manpage for free:

=head1

PURPOSE: Create an mksysb of servers listed in $path\mksysb.conf.
          Also, purge all mksysb's that are over an age set by the 
          filemaxage parameter.  

=cut
[download]

... then from the command line:

perldoc mksysb.pl
[download]

Comment on Re: check my code Select or Download Code

Replies are listed 'Best First'.
Re^2: check my code by graff (Chancellor) on Jul 14, 2010 at 05:09 UTC
Right ++! The template that I use for starting all my perl source files is something like this, which is pretty much what you see in most CPAN modules: `#!/usr/bin/perl =head1 NAME =head1 SYNOPSIS =head1 DESCRIPTION =cut use strict;` [download] I normally fill in the POD sections before I write any actual code. (This helps me establish and maintain focus, which tends to make the code easier and quicker to write.)	[reply] [d/l]

Replies are listed 'Best First'.

Re^2: check my code
by graff (Chancellor) on Jul 14, 2010 at 05:09 UTC

#!/usr/bin/perl

=head1 NAME

=head1 SYNOPSIS

=head1 DESCRIPTION

=cut

use strict;
[download]

[reply]
[d/l]