in reply to Re^2: 3par data acquistion
in thread 3par data acquistion

Use the "$_" scalar to work with individual lines inside the while loop. You can do something like this until you get comfortable with "$_"

next if (m/^$/);
last if (m/^Press.*/)       
my $line = $_; 
#grab bits here instead of using awk

[download]
I'd also suggest looking at split to put the data into variables: 
($rw,$io_s_cur,$io_s_avg,$io_s_max,$kb_s_cur,$kb_s_avg,$kb_s_max,$svt_
+ms_cur,$svt_ms_avg,$iosz_cur,$iosz_avg,$qlen) = split(/\s+/, $line, 1
+3);

[download]

The last bit is the first 3 lines in this output; unless you need them for something I'd use the "last if" in the first code block above as a starting point; change last to next and modify the match m//

Replies are listed 'Best First'.
Re^4: 3par data acquistion
by bluethundr (Pilgrim) on Aug 23, 2010 at 17:18 UTC
    I for some reason am getting the following error from my perl program I am trying to use to gather info from our 3par units. 

    "my" variable %parvalues masks earlier declaration in same scope at ./
+3par-test2.pl line 23.
"my" variable $parkeys masks earlier declaration in same statement at 
+./3par-test2.pl line 24.
"my" variable %parvalues masks earlier declaration in same statement a
+t ./3par-test2.pl line 24.
"my" variable $parkeys masks earlier declaration in same statement at 
+./3par-test2.pl line 24.
syntax error at ./3par-test2.pl line 22, near "$parvalues{"
Global symbol "$parelement" requires explicit package name at ./3par-t
+est2.pl line 22.
Execution of ./3par-test2.pl aborted due to compilation errors.

    [download]


    Could someone please explain why these "my" variable are not correctly declared?

    #!/usr/bin/perl
use strict;
use warnings;
use IO::Pipe;

my @systems = ('3par-S400','3par-E200');
my $system = undef;
my $output = undef;
my $command = undef;


foreach $system (@systems) { 

    $output = run_command($system);



    while (<$output>) {
        next if (m/^$/);
        last if (m/^Press.*/);
        #print $_ . "\n";
        my $parvalues{$parelement} = ($_ .=~/(.*?)\t+/g) {
        foreach my $parkeys (sort keys %parvalues){
        print $parkeys, "\t", $parvalues{$parkeys}, "\n";
          }
       }
        
 }

    close($output);

}


sub run_command {

my $system = shift;
my $protocol = 'ssh';
my $command = "statvv -ni";
my $space = " ";
#The following is bad but it works for now..
my $do_command = $protocol . $space . $system . $space . $command; 
my $cmd = new IO::Pipe;
$cmd->reader($do_command);
return $cmd;
   
    
}

    [download]


    thank you monks for all your help so far!
[reply]
[d/l]
[select]
      I suspect it's because the hash %parvalues; is what you're trying to 'my' each iteration of that loop not the element parelement. If you want to my it try doing that before you enter the <output> loop. FWIW: I'd do something like %parvalues = (); before the while which should prevent warn/strict from complaining; (This could be the wrong to define an 'empty hash'; I think it works the same as a list/array however)
[reply]

In Section Seekers of Perl Wisdom