Re^2: Perl task function

Hello, BrowserUk. Your solution is great, but there is one error: when I splice the array it's size decreases, so the cycle doesn't check the next element. Here is the fixed solution. I changed your syntax a little - you prefer a compact style, while I try to make the code more comprehensible - even placing some extra code.

my %dispatch = (
    SCALAR => sub{ return 1; },
    ARRAY  => sub {
        my $ref = shift;

        my $n = scalar(@$ref);
        for(my $i = 0; $i < $n; ++$i)
        {
            my $result = clean($ref->[ $i ]);
            if($result == 0)
            {
                splice(@$ref, $i, 1);
                $i--;
                $n--;
            }
         }

        unless(@$ref)
        {
            return 0;
        }
    },
    "HASH"  => sub {
            my $ref = shift;

            while(my ($key, $value) = each( %$ref))
            {
                  my $result = clean($value);

                  if ($result == 0) {
                        delete($ref->{$key});
                  }
            }

            my $n = scalar(keys %$ref);
            if ($n == 0) {
                  return 0;
            }
            return 1;
    },
    REF  => sub{ my $ref = shift; die "REF: $ref not allowed"; },
    CODE => sub{ my $ref = shift; die "CODE: $ref not allowed"; },
    ''  => sub{ return 1; },
);
[download]

ikegami, I don't understand your solution. There is no need to undef the scalars, and it didn't delete the empty arrays. Thanks for help, though.

Comment on Re^2: Perl task function Download Code

Replies are listed 'Best First'.
Re^3: Perl task function by ikegami (Patriarch) on Sep 09, 2010 at 15:16 UTC
ikegami, I don't understand your solution. Which part? I wrote it to be extremely straightforward. Each line is completely independent of the others. There is no need to undef the scalars, I think you mean there is no need to get rid of references to undef. If so, then just get rid of the following: `if ($reftype eq 'REF' \|\| $reftype eq 'SCALAR') { clean($$node); $node = undef if !defined($$node); } els` [download] (Like I said, very modular.) Read more... (706 Bytes) it didn't delete the empty arrays It both empties arrays (removes any undefs from them), and deletes references to empty arrays. I even showed that it does. Here's a couple more tests: `[[[],[],["b"]],"a"] [[["b"]],"a"] [[[],[],[]],"a"] ["a"]` [download] Could you give a case that breaks? `my $n = scalar(keys %$ref); if ($n == 0) { return 0; } return 1;` [download] I find it weird that clean() returns false when the node is clean (empty). Either way, your code could be simplified to `return keys(%$ref) ? 1 : 0;` [download] or even just `return keys(%$ref);` [download]	[reply] [d/l] [select]
Re^3: Perl task function by BrowserUk (Patriarch) on Sep 09, 2010 at 15:25 UTC
there is one error: when I splice the array it's size decreases, so the cycle doesn't check the next element. There is no error in my implementation. It does all elements, if you start from the end and work backward. Hence why my loop uses reverse: `for reverse 0 .. $#$ref;` [download] Your forward running C-style loop, using splice and requiring that you decrement `$i` & `$n` after deletions is rather clumsy and unperlish by comparison. But if that's what you're comfortable with, stick with it. Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error. "Science is about questioning the status quo. Questioning authority". In the absence of evidence, opinion is indistinguishable from prejudice. RIP an inspiration; A true Folk's Guy	[reply] [d/l] [select]