Re: "Voting Booth" nodelet is double escaping (CGI)

That's a bug in CGI.pm that we worked around with a custom wrapper for it. Now that the web servers were upgraded (with no notice), more work is still needed to restore full functionality (the site was down earlier).

- tye

Comment on Re: "Voting Booth" nodelet is double escaping (CGI)

Replies are listed 'Best First'.
Re^2: "Voting Booth" nodelet is double escaping (fixed) by tye (Sage) on Sep 16, 2010 at 17:56 UTC
This has been fixed. Actually, the custom wrapper for CGI.pm was fine but it doesn't work around these bugs. The wrapper causes '[' and ']' to be escaped in the appropriate places of generated HTML and adds newlines after generated `<tr>` tags (and defines a couple of methods that are never actually used at this point). There are a couple of (design) bugs in CGI.pm related to escaping the HTML of elements for which HTML does not need to be escaped. I have finally filed a bug related to those. You would think that fixing them would require making allowance for backward compatibility. But, maybe not... I've once again commented out a few lines (using "#!#" so they are easy to find) of a copy of CGI.pm and fixed those design bugs. I've also fixed a few changes to CGI.pm that broke backward compatibility (hence my ending to the previous paragraph). - tye	[reply] [d/l]

Replies are listed 'Best First'.

Re^2: "Voting Booth" nodelet is double escaping (fixed)
by tye (Sage) on Sep 16, 2010 at 17:56 UTC

This has been fixed.

Actually, the custom wrapper for CGI.pm was fine but it doesn't work around these bugs. The wrapper causes '[' and ']' to be escaped in the appropriate places of generated HTML and adds newlines after generated <tr> tags (and defines a couple of methods that are never actually used at this point).

There are a couple of (design) bugs in CGI.pm related to escaping the HTML of elements for which HTML does not need to be escaped. I have finally filed a bug related to those. You would think that fixing them would require making allowance for backward compatibility. But, maybe not...

I've once again commented out a few lines (using "#!#" so they are easy to find) of a copy of CGI.pm and fixed those design bugs. I've also fixed a few changes to CGI.pm that broke backward compatibility (hence my ending to the previous paragraph).

- tye

[reply]
[d/l]