in reply to Code Critique
What should decent code look like??I looked at your first line:
You require the program to have exactly three arguments. Your die message suggest two are needed. Looking through the code, it turns out you indeed use all three. But the last one almost at the bottom. Better to assign your arguments to meaningful variables at the top of your program.if ($#ARGV != 2){die "usage $0 filenamein filenameout\n";}
As for the rest of the code, the almost total lack of indentation makes it too hard to read. I'm not going to bother.
|
|---|