in reply to Changing variable names in a loop

If you don't use individual variables but collect them all into a %inc-hash you can do it in one go: (untested)
my %inc = map { $content =~ /inc_$_(.*?)\n/; $_ => $1 } qw(albums genres artists sonfs ratings year);
Now rather than using e.g. $inc_year, you use $inc{year}.

The same pattern can be used for the exclusions.

Replies are listed 'Best First'.
Re^2: Changing variable names in a loop
by eyepopslikeamosquito (Archbishop) on Oct 15, 2010 at 20:20 UTC

    A couple of (tested) minor variations on this solution.

    This one mimics your original by avoiding $1:

    my %inc = map { my ($v) = $content =~ /inc_$_=(.*?)\n/; $_ => $v } qw(albums genres artists songs ratings year);
    while this one does not insert into the hash if the regular expression does not match:
    my %inc = map { $content =~ /inc_$_=(.*?)\n/ ? ($_ => $1) : () } qw(albums genres artists songs ratings year);

      If you want to avoid $1 you can also do it like this (then you don't need a temporary variable):
      my %inc = map { $_ => ($content =~ /inc_$_=(.*?)\n/)[0]; } qw(albums genres artists songs ratings year);

        Unfortunately, that version does not work in the case of a non-matching regex, producing an invalid hash with an odd number of elements, because a non-match produces an empty list (not undef). It can be fixed with:

        my %inc = map { $_ => ($content =~ /inc_$_=(.*?)\n/)[0] || undef } qw(albums genres artists songs ratings year);
        Update: The || above should be // to cater for the edge case of "inc_artists=0". Note that the // "defined or" operator was added to Perl 5.10. Note further that the low precedence version of this operator has morphed from err to dor to orelse; orelse is in Perl 6 as a similar but not identical low precedence version of //, but not in Perl 5 AFAICT.

        Test program to demonstrate follows. Running:

        use strict; use warnings; use Data::Dumper; my $content = <<'GROK'; inc_albums=albumvalue inc_genres=genrevalue inc_artists =artistvalue inc_songs=songsvalue inc_ratings=ratingsvalue inc_year=yearvalue GROK { my %inc = map { my ($v) = $content =~ /inc_$_=(.*?)\n/; $_ => $v } qw(albums genres artists songs ratings year); print Dumper(\%inc); } { my %inc = map { $_ => ($content =~ /inc_$_=(.*?)\n/)[0]; } qw(albums genres artists songs ratings year); print Dumper(\%inc); } { my %inc = map { $_ => ($content =~ /inc_$_=(.*?)\n/)[0] || undef } qw(albums genres artists songs ratings year); print Dumper(\%inc); }
        produces:
        $VAR1 = { 'artists' => undef, 'ratings' => 'ratingsvalue', 'songs' => 'songsvalue', 'genres' => 'genrevalue', 'albums' => 'albumvalue', 'year' => 'yearvalue' }; Odd number of elements in hash assignment at ff2.pl line 21. $VAR1 = { 'ratingsvalue' => 'year', 'songsvalue' => 'ratings', 'artists' => 'songs', 'genres' => 'genrevalue', 'yearvalue' => undef, 'albums' => 'albumvalue' }; $VAR1 = { 'artists' => undef, 'ratings' => 'ratingsvalue', 'songs' => 'songsvalue', 'genres' => 'genrevalue', 'albums' => 'albumvalue', 'year' => 'yearvalue' };