|
Re^2: Renaming an image file
by morgon (Priest) on Nov 28, 2010 at 06:54 UTC
|
| [reply] |
|
|
I would use a digest not of the file content, but of the file name (computationally cheaper and no collisions possible).
What makes you think that a filename has the special property of returning a unique value for each and every hash function? Hash functions always have collisions, by definition. You can't losslessly compress arbitary amounts of data into 128, 256 or 512 bits. Sure, it is unlikely that two short names share the same hash value, but it is not impossible. And with filenames near MAX_PATH, which is 4 KBytes on Linux and perhaps even larger on other systems, collisions become more likely.
If you are on a unix-filesystem I would use the inode-number of the file (you get that with stat).
The inode is not unique, it is just unique per filesystem. Together with the device number, it should be unique. Problems start when the filesystem layer of the OS kernel has to invent inode numbers for filesystems that do not have inodes. Linux does that for at least the FAT-based filesystems, in linux/fs/fat/inode.c.
Alexander
--
Today I will gladly share my knowledge and experience, for there are no sweeter words than "I told you so". ;-)
| [reply]
[d/l]
[select] |
|
|
You are of course right regarding the collisons.
What I meant was that when using filenames rather then content for hashing, you avoid the case that you have 2 files with the same content, thus resulting in a (trivial) collision that can be avoided by hashing the name.
| [reply] |
|
|
|
|
|
|
|
Not withstanding afoken's very good points above, the OP is combining his random number with part of the original filename.
I was suggesting he do the same with the MD5, which covers the possibility of there being two copies of the same content under different names in the same directory.
I would also combine the file length into the derived number, as probabilistically, each MD5 will repeat once in each set of files of length modulus 16.
| [reply] |
Re^2: Renaming an image file
by Anonymous Monk on Nov 28, 2010 at 16:24 UTC
|
How to use Digest::MD5 in this file name rename code?
If joe_34455667.jpg or Mary_8883377.jpg etc...
...
my $file=~s/^([^_]+_)(.*)(\.\w{3})\z/$1.md5_hex($2).$3/eg;
...
| [reply]
[d/l] |
|
|
Your code is replacing the number with the md5 of that number, which is a poor idea.
My suggestion was that you replace the number with the md5 of the files contents. Something like:
my $file = 'joe_34455667.jpg';
my $md5 = md5_hex( do{ local( @ARGV, $/) = $file; <> } );
$file =~ s[_(\d+)\.jpg$][_$md5.jpg];
Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
"Science is about questioning the status quo. Questioning authority".
In the absence of evidence, opinion is indistinguishable from prejudice.
| [reply]
[d/l] |
|
|
This line is confusing to me,
my $md5 = md5_hex( do{ local( @ARGV, $/) = $file; <> } );
If I run your code:
my $file = 'joe_34455667.jpg';
my $md5 = md5_hex( do{ local( @ARGV, $/) = $file; <> } );
$file =~ s[_(\d+)\.jpg$][_$md5.jpg];
I get "use of uninitialized value $_ in substitution (s///)
My goal is just replace the file names with some name that is not going to be the same insisde of this directory, why replacing the number with the md5 of that number is a poor idea?
| [reply]
[d/l]
[select] |
|
|
|
|
|