prepare insert statement outside while loop for speed

Anonymous Monk has asked for the wisdom of the Perl Monks concerning the following question:

Esteemed monks

I am new to perl and trying to get to grips with the dbi. Is this the correct way to prepare an insert statement outside a while loop for speed?

my $insert_snp_sql = "insert into $tableName (Chr, Pos_start, Pos_end,
+  id, reference, genotype) values (?,?,?,?,?,?)";
my $sth = $db->prepare ($insert_snp_sql);  
while(<INFH>){
#process input line and then insert to database       

        if ($sth->execute($data[0],$data[1],$data[2], $data[3], $data[
+4],$data[5])) {
              #insert ok
       }
}
[download]

thanks a lot

Comment on prepare insert statement outside while loop for speed Download Code

Replies are listed 'Best First'.
Re: prepare insert statement outside while loop for speed by JavaFan (Canon) on Dec 01, 2010 at 20:34 UTC
Yes.	[reply]
Re^2: prepare insert statement outside while loop for speed by Anonymous Monk on Dec 01, 2010 at 20:46 UTC
thanks!	[reply]
Re: prepare insert statement outside while loop for speed by McDarren (Abbot) on Dec 02, 2010 at 05:19 UTC
`$sth->execute($data[0],$data[1],$data[2], $data[3], $data[4],$data[5])` [download] The above could be written a bit more succinctly as: `$sth->execute(@data[0 .. 5])` [download] See Slices Or, if you know that `@data` will always contain just six elements, then just simply: `$sth->execute(@data)` [download] Hope this helps, Darren	[reply] [d/l] [select]