Use $newline in your comparison.

Thank you it works now, I have one more question, coupld you tell me whether this is the correct method to call a perl script from another script?

if($size_EG12>0){
    system "java StopMessageFlows";
    foreach(@EG12){
        do 'deploy.pl';
        }
        }
[download]

Your script already calls a java program, so simply call other perl scripts in the same way.

Peter (Guo) Pei

Here is the syntax:

use strict;
use warnings;
use 5.010;

my @answers = qw{yes no maybe};

for my $string (@answers) {
    say $string;

    #or do something else to $string
}
[download]

Every element of @answers gets assigned to the variable $string in turn.

There are several perl functions that can be used to call external programs. system() is one of them. One respect in which the functions differ is in their return values.

@EG01 = ($artefact) x grep {$_ eq 'QT95EG01'} @new2;
@EG02 = ($artefact) x grep {$_ eq 'QT95EG02'} @new2;
[download]

Looks cool, but won't your solution require grep to loop through @new2 twice (once for each grep)?

Performance wise, isn't a single foreach loop, with two conditionals better?

You mean, it's faster to do N * 2 comparisons than 2 * N comparisons?

If you really care, benchmark. Both will do the same amount of comparisons, but the grep probably uses less opcodes. On top of that, the grep only does one assignment/push per array. Regardless of the number of matches.

Not that I care. I find the grep version clearer: the important part is the modification (setting or pushing) of the arrays, and they are in front with the grep solution, instead of buried inside the foreach.

And in general, I'd prefer a solution that doesn't need indentation over one that goes two levels deep. (Deepness of indentation is a rough estimate of complexity (yeah, yeah, hold the counterexamples)).