jonnyw83:

You're already working with people on some answers, so this post is just a couple observations about your code.

First, I'm wondering if using a pair of hashes with identical keys is a good idea. It can be, but I can't tell without knowing more about your program. I tend to use a single hash, and add a level to handle the split. For example, if you're comparing the contents of a pair of files, rather than having a hash for each file, you could add keys (such as FILE1 and FILE2) for the different files after your primary key:

for my $key (keys %hash) {
   if (exists $hash{$key}{FILE1}) {
      if (exists $hash{$key}{FILE2}) {
         # Key exists in both files
      }
      else {
         # Key exists only in file 1
      }
   }
   else {
      # Key exists only in file 2
   }
}
[download]

Second: if you choose a different indentation style, you wouldn't need the comments that tell you '#closes if loop' -- good use of whitespace can make it obvious. There are quite a few different indentation styles that can make it clear. For example, you can vertically align the closing curly brace with the structure that's being closed:

foreach my $key (keys (%hasha)) {
   if (my @temp = grep( /$key/, @prevarray ) ) {
      push(@{$hasha{$key}},$value);
      next;
   }
   else {
      push (@{$hashb{$key}},$value);
      next;
   }
}
[download]

Another popular method is to vertically align the open and closing curly braces, either indented:

foreach my $key (keys (%hasha))
   {
   if (my @temp = grep( /$key/, @prevarray ) )
      {
      push(@{$hasha{$key}},$value);
      next;
      }
   else
      {
      push (@{$hashb{$key}},$value);
      next;
      }
   }
[download]

or not:

foreach my $key (keys (%hasha))
{
   if (my @temp = grep( /$key/, @prevarray ) )
   {
      push(@{$hasha{$key}},$value);
      next;
   }
   else
   {
      push (@{$hashb{$key}},$value);
      next;
   }
}
[download]

There are many variations, and plenty of religious wars over indentation style. Don't get caught up in the wars, just be consistent within each script. Most people can easily get used to any of the styles fairly quickly, so don't get too hung up on it.

...roboticus

When your only tool is a hammer, all problems look like your thumb.