in reply to Help with the push function

Sorry for not looking up your previous posts (if they're relevant to this question, it might help to include links to those threads). But just looking at this OP, I wonder:

Usually, a <ul>...</ul> element contains multiple <li>...</li> elements, but your initial regex assumes there is never more than one "li" within a given "ul". But if you're sure that "answers" are always marked up that way, then that should be fine.

After each regex, you are pushing the whole (remaining) content of $line onto your answers array, but I think you really want to push @answers, $1;

Apart from that, it might help to provide some sample input, and a sample of what you would want as a result (intended contents of @answers and @questions).

Replies are listed 'Best First'.
Re^2: Help with the push function
by mistamutt (Novice) on Feb 16, 2011 at 06:58 UTC

    The HTML document I'm trying to write this for is rather simple. It's a ordered list of quiz questions, followed by answers like this:

    <ol>
<li>
Question? Answer.
<li>
Question? Answer.
<li>
Statement. Response to statement.
<li>
Question?
<pre>Answer</pre>
</ol>

    [download]

    What I'm trying to do is, get all of the questions into an array, and then put the quiz into a hash of questions and corresponding answers. So far I've removed the code, and span tags, removed the whitespace, and the extra newline characters. The questions always follow an <li> tag, with the answers coming after a question mark most times, but sometimes they follow <pre> tags and end at the closing pre tag, and some "questions" aren't questions at all and are statements that you respond to.

    I tried to push @questions, $1 but it still isn't printing anything when I 

    foreach(@questions) {
print "$_\n";

    [download]

[reply]
[d/l]
[select]
      I tried to push @questions, $1 but it still isn't printing anything when I...

      There's no mention of "push" in the code snippet following that statement, so we don't know what "tried to push @questions, $1 really means in this context. To recap the discussion so far: first you present some code, but no data, then some data (with a different problem) but no code. Dude, we cannot see the things in your head, or the things you see on your terminal but don't show us. Please try harder to be coherent.

      The HTML document I'm trying to write this for is rather simple. It's a ordered list of quiz questions, followed by answers like this:

      "Rather simple" seems apt for describing the markup (though it actually looks like it'll be prone to unpredictable variability) But the information content -- esp. the "Statement. Response to statement." case -- is only simple for human readers who know the language well enough that they can easily figure out which periods mark sentence boundaries (and which ones don't), and can tell the difference between a "statement" and a "response to a statement." (And BTW, have you noticed that sometimes an "answer" to a "question" contain another question?)

      You don't say how much data of this sort you have to deal with, but if it gets to more than several dozen "statement. response." type cases, you can expect some edge cases that may need to be resolved by a human editor.

      If you get acquainted with something like HTML::Parser or HTML::TokeParser, you'll have an easier time dealing with variable mark-up, so you can focus on the harder problem of parsing the information content (where the essential division you need to find might not be marked in any consistent or explicit way).

      In pseudo-code terms, you probably want something like: 

      # setup the parser to capture the contents of all <li> chunks into @ar
+ray, then

foreach ( @array ) {
    if ( m{(.*?)<pre>(.*)</pre>}s  # NB: "?" makes ".*" non-greedy
         or /(.*\?)\s+(\S.*)/s     # NB: "\?" matches a literal qmark 
         or /^([^.]+)\.\s+([^.]+\.)\s*$/s ) {
        push @questions, $1;
        push @answers, $2;
    }
    else {
        # you have a harder case to solve (might need a human)
    }
}

      [download]
      If you have trouble with that, it'll be okay to start a new thread -- it'll be something other than "help with the push function"...

      (updated last code snippet to correct a mistaken comment about "?")

[reply]
[d/l]
[select]

In Section Seekers of Perl Wisdom