Re^2: Yet more While issues

I got it - at least it's stopped throwing warnings and it's a whole lot faster that what I had before.

Since popnum3 is called from inside an if/else

else {
   my $pos = -1;
   push @cPosns, $pos while ($pos = index($zazb, 'c', $pos+1)) >= 0;
   my $offset = $cPosns[rand @cPosns];
   $cell = sprintf '%.2f', popnum3( $x, $y, $copycop, $offset, );
}
[download]

then

sub popnum3 {
    my ( $x, $y, $z, $offset ) = @_;
    if ( $y == 0 ) {
        $aob[$x][0] = $initial * ( 1 + $z );
    }
    else {
        while (1) {
            $aob[$x][$y] = $aob[$offset][ $y - 1 ] * ( 1 + $z );
            last;
        }
    }
    return $aob[$x][$y];
}
[download]

So far it's looking good. Thanks

Comment on Re^2: Yet more While issues Select or Download Code

Replies are listed 'Best First'.
Re^3: Yet more While issues by ikegami (Patriarch) on Mar 16, 2011 at 22:38 UTC
What's with the useless `while(1) { ...; last; }` again?	[reply] [d/l]
Re^4: Yet more While issues by Dandello (Monk) on Mar 17, 2011 at 19:48 UTC
Habit I'm still trying to get everything configured to work right - When I have the code set up like this: `else { my $pos = -1; push @cPosns, $pos while ($pos = index($zazb, 'c', $pos+1)) >= 0; my $offset = $cPosns[rand @cPosns]; $cell = sprintf '%.2f', popnum3( $x, $y, $copycop, $offset, ); }` [download] then `sub popnum3 { my ( $x, $y, $z, $offset ) = @_; if ( $y == 0 ) { $aob[$x][0] = $initial * ( 1 + $z ); } else { while (1) { $aob[$x][$y] = $aob[$offset][ $y - 1 ] * ( 1 + $z ); last; } } return $aob[$x][$y]; }` [download] It's reiterating over the entire string for every single 'a' or 'c' which starts fast then slows to a crawl When I move this section `my $pos = -1; push @cPosns, $pos while ($pos = index($zazb, 'c', $pos+1)) >= 0;` [download] above all the if/else's, to just under where `$zazb` is defined, then the $offset variable in `else { my $offset = $cPosns[rand @cPosns]; $cell = sprintf '%.2f', popnum3( $x, $y, $copycop, $offset, ); }` [download] becomes undefined when imported into popnum3. So obviously I'm still missing something. There is always at least 1 'c' in the string so that's not the problem.	[reply] [d/l] [select]