Re: C any bugs?

Quickly, why mix up subroutines and large chunks of code? May I suggest something like:

&sub_one;
&sub_two;
&sub_three;

sub sub_one{
}

sub sub_two{
}

sub sub_three{
}
[download]

I think that this is clearer and easier to understand. It maximises the benefit of using subroutines.

Other than that I agree with the above comments on CGI and strict. CGI is very important from an upkeep point of view - so long as you keep your CGI module up to date you don't have to worry about rewriting your code to match the latest standards. strict is a very useful learning tool.

"The significant problems we face in life can not be solved at the same level of thinking we were at when we created them." -Albert Einstein

Comment on Re: C any bugs? Download Code

Replies are listed 'Best First'.
Re (tilly) 2: C any bugs? by tilly (Archbishop) on Jun 18, 2001 at 23:15 UTC
Unless you have a specific reason to use the implicit argument list, it is best to use parens in calling functions. If this comment made no sense to you, the following summary may help. Also functions should be given names that clearly describe what they do. Inability to find a meaningful name for a function is usually an excellent indicator that the code is not well factored. Certainly having a function whose name does not properly describe what it does is almost always a maintainance problem...	[reply]

Replies are listed 'Best First'.

Re (tilly) 2: C any bugs?
by tilly (Archbishop) on Jun 18, 2001 at 23:15 UTC

If this comment made no sense to you, the following summary may help.

Also functions should be given names that clearly describe what they do. Inability to find a meaningful name for a function is usually an excellent indicator that the code is not well factored. Certainly having a function whose name does not properly describe what it does is almost always a maintainance problem...

[reply]